linux-kernel - Re: [RFC PATCHv2 07/19] mfd: ab8500: Use power_supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 Jan 2015 15:16:16 +0100
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <lenb@...nel.org>,
	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Pavel Machek <pavel@....cz>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [RFC PATCHv2 07/19] mfd: ab8500: Use power_supply_*() API for
 accessing function attrs

On wto, 2015-01-20 at 13:36 +0000, Lee Jones wrote:
> On Mon, 05 Jan 2015, Krzysztof Kozlowski wrote:
> 
> > Replace direct calls to power supply function attributes with wrappers.
> > Wrappers provide safe access in case of unregistering the power
> > supply (e.g. by removing the driver). Replace:
> >  - get_property -> power_supply_get_property
> > 
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> > Acked-by: Jonghwa Lee <jonghwa3.lee@...usng.com>
> > Acked-by: Pavel Machek <pavel@....cz>
> > Acked-by: Lee Jones <lee.jones@...aro.org>
> 
> You've sent this to me already Acked.  I don't see 00/00, so I have no
> idea what's going on.  Do you want me to take this patch?  Can it be
> taking on its own?

git send-email automatically CC-you because you acked this. The depends
on previous patches adding this API so please do not pick it up. 

Everything (with respective acks) should go through one power supply
tree.

The same applies to patch 18/19.

Best regards,
Krzysztof

> 
> > ---
> >  drivers/mfd/ab8500-sysctrl.c | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/mfd/ab8500-sysctrl.c b/drivers/mfd/ab8500-sysctrl.c
> > index cfff0b643f1b..d4a4b24be7c6 100644
> > --- a/drivers/mfd/ab8500-sysctrl.c
> > +++ b/drivers/mfd/ab8500-sysctrl.c
> > @@ -49,7 +49,8 @@ static void ab8500_power_off(void)
> >  		if (!psy)
> >  			continue;
> >  
> > -		ret = psy->get_property(psy, POWER_SUPPLY_PROP_ONLINE, &val);
> > +		ret = power_supply_get_property(psy, POWER_SUPPLY_PROP_ONLINE,
> > +				&val);
> >  
> >  		if (!ret && val.intval) {
> >  			charger_present = true;
> > @@ -63,8 +64,8 @@ static void ab8500_power_off(void)
> >  	/* Check if battery is known */
> >  	psy = power_supply_get_by_name("ab8500_btemp");
> >  	if (psy) {
> > -		ret = psy->get_property(psy, POWER_SUPPLY_PROP_TECHNOLOGY,
> > -					&val);
> > +		ret = power_supply_get_property(psy,
> > +				POWER_SUPPLY_PROP_TECHNOLOGY, &val);
> >  		if (!ret && val.intval != POWER_SUPPLY_TECHNOLOGY_UNKNOWN) {
> >  			printk(KERN_INFO
> >  			       "Charger \"%s\" is connected with known battery."
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/