linux-kernel - Re: [patch] mm: memcontrol: default hierarchy interface for memory fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150120143002.GB11181@phnom.home.cmpxchg.org>
Date:	Tue, 20 Jan 2015 09:30:02 -0500
From:	Johannes Weiner <hannes@...xchg.org>
To:	Michal Hocko <mhocko@...e.cz>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Vladimir Davydov <vdavydov@...allels.com>,
	Greg Thelen <gthelen@...gle.com>, linux-mm@...ck.org,
	cgroups@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [patch] mm: memcontrol: default hierarchy interface for memory
 fix - "none"

On Tue, Jan 20, 2015 at 02:37:11PM +0100, Michal Hocko wrote:
> On Sat 17-01-15 10:21:47, Johannes Weiner wrote:
> > The "none" name for the low-boundary 0 and the high-boundary maximum
> > value can be confusing.
> > 
> > Just leave the low boundary at 0, and give the highest-possible
> > boundary value the name "max" that means the same for controls.
> 
> max might be confusing as well because it matches with the knob name.
> max_resource or max_memory sounds better to me.

These names are appalling in the same way that memory.limit_in_bytes
is.  They are too long, while their information density is low.  They
make you type out the unit that should be painfully obvious to anybody
doing the typing.  And they still overlap with the knob name!

$ cat memory.max
max_memory

Really?

Another possibility would be "infinity", but tbh I think "max" is just
fine.  It's descriptive, the potential for confusion is low and easily
eliminated with documentation, and it's short and easy to type.

> Btw. I would separate page_counter_memparse change out and
> replace the original 'mm: page_counter: pull "-1" handling out of
> page_counter_memparse()' by it.

Yeah, that would probably make sense, but we can't do it incrementally
anymore.  Andrew, want me to resend these two patches with all fixes
incorporated?

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/