linux-kernel - Re: [PATCH] coresight-etm: remove check for unknown Kconfig macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANLsYkzgiX_ZkQVEU-o4VE=LQB=daw1a3WCOkm45bdBHWg72tg@mail.gmail.com>
Date:	Tue, 20 Jan 2015 08:11:56 -0700
From:	Mathieu Poirier <mathieu.poirier@...aro.org>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Valentin Rothberg <valentinrothberg@...il.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] coresight-etm: remove check for unknown Kconfig macro

On 19 January 2015 at 10:44, Paul Bolle <pebolle@...cali.nl> wrote:
> The CoreSight ETM/PTM driver contains a check for a
> CONFIG_CORESIGHT_SOURCE_ETM_DEFAULT_ENABLE macro. But there's no related
> Kconfig symbol CORESIGHT_SOURCE_ETM_DEFAULT_ENABLE. Remove that check
> and the single line of code it hides.
>
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> ---
> Cross-compile tested only (on top of next-20150119).
>
>  drivers/coresight/coresight-etm3x.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/coresight/coresight-etm3x.c b/drivers/coresight/coresight-etm3x.c
> index 73c36696f1b6..f312dc4dd95c 100644
> --- a/drivers/coresight/coresight-etm3x.c
> +++ b/drivers/coresight/coresight-etm3x.c
> @@ -34,11 +34,7 @@
>
>  #include "coresight-etm.h"
>
> -#ifdef CONFIG_CORESIGHT_SOURCE_ETM_DEFAULT_ENABLE
> -static int boot_enable = 1;
> -#else
>  static int boot_enable;
> -#endif
>  module_param_named(
>         boot_enable, boot_enable, int, S_IRUGO
>  );
> --
> 1.9.3
>

Applied - with a slight modification to keep the "module_param_named"
macro on the same line.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/