linux-kernel - Re: [PATCH v4 2/6] mfd: MT6397: Add support for PMIC MT6397 MFD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150120153301.GZ13701@x1>
Date:	Tue, 20 Jan 2015 15:33:01 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Sascha Hauer <s.hauer@...gutronix.de>
Cc:	Flora Fu <flora.fu@...iatek.com>,
	Mark Rutland <mark.rutland@....com>,
	Menghui Lin <menghui.lin@...iatek.com>,
	Russell King <linux@....linux.org.uk>,
	Samuel Ortiz <sameo@...ux.intel.com>, arm@...nel.org,
	Grant Likely <grant.likely@...aro.org>,
	Yingjoe Chen <yingjoe.chen@...iatek.com>,
	devicetree@...r.kernel.org, Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	HenryC Chen <henryc.chen@...iatek.com>,
	Rob Herring <robh+dt@...nel.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Eddie Huang <eddie.huang@...iatek.com>,
	linux-arm-kernel@...ts.infradead.org,
	Dongdong Cheng <dongdong.cheng@...iatek.com>,
	srv_heupstream@...iatek.com, linux-kernel@...r.kernel.org,
	Arnd Bergmann <arnd@...db.de>,
	Sascha Hauer <kernel@...gutronix.de>,
	Kumar Gala <galak@...eaurora.org>,
	Olof Johansson <olof@...om.net>,
	Chen Zhong <chen.zhong@...iatek.com>
Subject: Re: [PATCH v4 2/6] mfd: MT6397: Add support for PMIC MT6397 MFD

On Tue, 20 Jan 2015, Sascha Hauer wrote:

> Hi Lee,
> 
> On Tue, Jan 20, 2015 at 02:43:09PM +0000, Lee Jones wrote:
> > On Fri, 26 Dec 2014, Flora Fu wrote:
> > 
> > > Add core files for MT6397 MFD driver.
> > > 
> > > Signed-off-by: Flora Fu <flora.fu@...iatek.com>
> > > ---
> > >  drivers/mfd/Kconfig                  |  10 +
> > >  drivers/mfd/Makefile                 |   1 +
> > >  drivers/mfd/mt6397-core.c            |  94 +++++++++
> > >  include/linux/mfd/mt6397/core.h      |  23 +++
> > >  include/linux/mfd/mt6397/registers.h | 362 +++++++++++++++++++++++++++++++++++
> > >  5 files changed, 490 insertions(+)
> > >  create mode 100644 drivers/mfd/mt6397-core.c
> > >  create mode 100644 include/linux/mfd/mt6397/core.h
> > >  create mode 100644 include/linux/mfd/mt6397/registers.h
> > 
> > Looks okay.
> > 
> > I assume there are dependancies on this patch.  What are they?
> > 
> > How would you like this set to be handled?
> 
> This patch is outdated, I sent an updated series today (you are on Cc).

Okay, thanks.

> There are no compile time dependencies to the PMIC wrapper, but without
> it the mfd part is pretty useless. I prefer to keep the series together
> and merge it through arm-soc, but I would be fine with merging it
> through mfd aswell.

Yes, everyone feels the same about their cross-subsystem patch-sets. ;)

If there are build-time dependencies I am always happy to take sets
in via MFD and send out pull-requests to other subsystem Maintainers;
however, if there are only run-time dependencies I prefer to save
everyone the hassle and have them go in via their own subsystems.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/