linux-kernel - Re: [PATCH/RFC v10 07/19] mfd: max77693: Adjust FLASH_EN_SHIFT and TORCH_EN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150120154029.GC13701@x1>
Date:	Tue, 20 Jan 2015 15:40:29 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Jacek Anaszewski <j.anaszewski@...sung.com>
Cc:	linux-leds@...r.kernel.org, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	kyungmin.park@...sung.com, b.zolnierkie@...sung.com, pavel@....cz,
	cooloney@...il.com, rpurdie@...ys.net, sakari.ailus@....fi,
	s.nawrocki@...sung.com, Chanwoo Choi <cw00.choi@...sung.com>
Subject: Re: [PATCH/RFC v10 07/19] mfd: max77693: Adjust FLASH_EN_SHIFT and
 TORCH_EN_SHIFT macros

On Tue, 20 Jan 2015, Jacek Anaszewski wrote:

> On 01/20/2015 02:01 PM, Jacek Anaszewski wrote:
> >On 01/20/2015 12:17 PM, Lee Jones wrote:
> >>On Fri, 09 Jan 2015, Jacek Anaszewski wrote:
> >>
> >>>Modify FLASH_EN_SHIFT and TORCH_EN_SHIFT macros to work properly
> >>>when passed enum max77693_fled values (0 for FLED1 and 1 for FLED2)
> >>>from leds-max77693 driver.
> >>
> >>Off-by-one ay?  Wasn't the original code tested?
> >
> >The driver using these macros is a part of LED / flash API integration
> >patch series, which still undergoes modifications and it hasn't
> >reached its final state yet, as there are many things to discuss.
> 
> To be more precise: the original code had been tested and was working
> properly with the header that is in the mainline. Nonetheless, because
> of the modifications in the driver that was requested during code
> review, it turned out that it would be more convenient to redefine the
> macros.
> 
> I'd opt for just agreeing about the mfd related patches and merge
> them no sooner than the leds-max77693 driver is merged.

The only way we can guarantee this is to have them go in during
different merge-windows, unless of course they go in via the same tree.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/