linux-kernel - Re: [PATCH 3.19-rc2 v15 5/8] arm: omap1: Migrate debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150120160448.GC7718@atomide.com>
Date:	Tue, 20 Jan 2015 08:04:48 -0800
From:	Tony Lindgren <tony@...mide.com>
To:	Daniel Thompson <daniel.thompson@...aro.org>
Cc:	Russell King <linux@....linux.org.uk>,
	Arnd Bergmann <arnd@...db.de>, Paul Bolle <pebolle@...cali.nl>,
	linaro-kernel@...ts.linaro.org, patches@...aro.org,
	spear-devel@...t.st.com, linux-kernel@...r.kernel.org,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	John Stultz <john.stultz@...aro.org>,
	Arnd Bergmann <arnd.bergmann@...aro.org>,
	linux-omap@...r.kernel.org, Sumit Semwal <sumit.semwal@...aro.org>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 3.19-rc2 v15 5/8] arm: omap1: Migrate debug_ll macros to
 use 8250.S

* Daniel Thompson <daniel.thompson@...aro.org> [150120 01:03]:
> On 19/01/15 21:38, Tony Lindgren wrote:
> > * Daniel Thompson <daniel.thompson@...aro.org> [150105 04:49]:
> >> The omap1's debug-macro.S is similar to the generic 8250 code. Compared to
> >> the 8520 code the omap1 macro automatically determines what UART to use
> >> based on breadcrumbs left by the bootloader and automatically copes with
> >> the eccentric register layout on OMAP7XX.
> >>
> >> This patch drops both these features and relies instead on the generic
> >> 8250 macros:
> >>
> >> 1. Dropping support for the bootloader breadcrumbs is identical to the
> >>    way the migration was handled for OMAP2 (see 808b7e07464d...).
> >>
> >> 2. Support for OMAP7XX still exists but it must be configured by hand
> >>    (DEBUG_OMAP7XXUART1/2/3) rather than handled at runtime.
> >>
> >> Signed-off-by: Daniel Thompson <daniel.thompson@...aro.org>
> >> Cc: Russell King <linux@....linux.org.uk>
> >> Cc: Arnd Bergmann <arnd.bergmann@...aro.org>
> >> Cc: linux-omap@...r.kernel.org
> >> Tested-by: Aaro Koskinen <aaro.koskinen@....fi>
> >> Acked-by: Tony Lindgren <tony@...mide.com>
> > 
> > Daniel, I suggest you upload this patch into Russell's patch tracking
> > system to get it merged. That at least shrinks down your patch series
> > if the other patches need more work.
> 
> This has been in the patch tracker for a week or so:
> http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=8271/1

OK good to hear thanks.
 
> I'm very aware that this patch (and indeed the whole patch set) has been
> knocking round for longer than it should have. The changelog for this
> patchset is certainly not one to be especially proud off ;-) .

Yeah, it's been floating around for a while :)

Here it may have been doable to first add the Kconfig entries, then
flip them on and remove the related .S file in a follow up patch. Not
sure if that would have helped to remove the dependencies for the
rest of the series though.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/