linux-kernel - Re: [PATCH RESEND v2 5/7] mfd: cros_ec: Instantiate ChromeOS EC character device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150120162952.GB30656@x1>
Date:	Tue, 20 Jan 2015 16:29:52 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
Cc:	Olof Johansson <olof@...om.net>,
	Doug Anderson <dianders@...omium.org>,
	Bill Richardson <wfrichar@...omium.org>,
	Simon Glass <sjg@...gle.com>,
	Gwendal Grignou <gwendal@...gle.com>,
	Jonathan Corbet <corbet@....net>,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND v2 5/7] mfd: cros_ec: Instantiate ChromeOS EC
 character device

On Tue, 20 Jan 2015, Javier Martinez Canillas wrote:

> Hello Lee,
> 
> Thanks a lot for your feedback.
> 
> On 01/20/2015 09:20 AM, Lee Jones wrote:
> > On Fri, 02 Jan 2015, Javier Martinez Canillas wrote:
> > 
> >> The ChromeOS EC character device is an user-space interface to
> >> allow applications to access the Embedded Controller.
> >> 
> >> Add a cell for this device so it's spawned from the mfd driver.
> >> 
> >> Signed-off-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>
> >> ---
> >> 
> >> Changes since v1: None, new patch.
> >> 
> >>  drivers/mfd/cros_ec.c | 4 ++++
> >>  1 file changed, 4 insertions(+)
> >> 
> >> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
> >> index c872e1b..70f9ed5 100644
> >> --- a/drivers/mfd/cros_ec.c
> >> +++ b/drivers/mfd/cros_ec.c
> >> @@ -118,6 +118,10 @@ static const struct mfd_cell cros_devs[] = {
> >>  		.id = 2,
> >>  		.of_compatible = "google,cros-ec-i2c-tunnel",
> >>  	},
> >> +	{
> >> +		.name = "cros-ec-dev",
> > 
> > *-dev is seldom suitable for naming things.
> > 
> > Please be more imaginative/descriptive in your naming.
> >
> 
> You know this is one of the two hard problems in CS ;-)
> 
> But seriously, this is the name used in the downstream ChromiumsOS kernel
> and tbh I don't think is that bad since after all is a character device
> interface to access the Embedded Controller from user-space. So in that
> sense is not worse than the i2c-dev or spidev names but I can try to come
> up with something more creative if that will block the patch to be merged.

It's not a blocker, but it is a ridiculous name to use inside the
driver/ directory 'cos almost everything is a dev(ice) here.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/