linux-kernel - RE: [PATCH V3 2/2] devicetree: Add bindings for DA9063

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7D0B52E11@SW-EX-MBX02.diasemi.com>
Date:	Tue, 20 Jan 2015 16:35:27 +0000
From:	"Opensource [Steve Twiss]" <stwiss.opensource@...semi.com>
To:	Lee Jones <lee.jones@...aro.org>
CC:	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Mark Rutland <mark.rutland@....com>,
	Pawel Moll <pawel.moll@....com>,
	Rob Herring <robh+dt@...nel.org>,
	DT <devicetree@...r.kernel.org>,
	David Dajun Chen <david.chen@...semi.com>,
	Grant Likely <grant.likely@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Mark Brown <broonie@...aro.org>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Support Opensource <Support.Opensource@...semi.com>
Subject: RE: [PATCH V3 2/2] devicetree: Add bindings for DA9063

On 20 January 2015 15:54 Lee Jones wrote:

[...]

> >  Documentation/devicetree/bindings/mfd/da9063.txt | 93
> ++++++++++++++++++++++++
> >  1 file changed, 93 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/da9063.txt
> 
> I already Acked this?  Any reason that wasn't carried forward to this
> submission?  Has anything changed?
> 

Yes, I had to alter this bindings document because of the compatible change ...
See below:

> > new file mode 100644
> > index 0000000..42c6fa6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/da9063.txt
> > @@ -0,0 +1,93 @@
> > +* Dialog DA9063 Power Management Integrated Circuit (PMIC)
> > +
> > +DA9093 consists of a large and varied group of sub-devices (I2C Only):
> > +
> > +Device                   Supply Names    Description
> > +------                   ------------    -----------
> > +da9063-regulator        :               : LDOs & BUCKs
> > +da9063-rtc              :               : Real-Time Clock
> > +da9063-watchdog         :               : Watchdog
> > +
> > +======
> > +
> > +Required properties:
> > +
> > +- compatible : Should be "dlg,da9063"

The line above used to say "dlg,da9063-ad", "dlg,da9063-bb", etc.
Now it just says "dlg,da9063"

[...]

> > +
> > +Example:
> > +
> > +	pmic0: da9063@58 {
> > +		compatible = "dlg,da9063"

And I also change a  line in the example for the same reason.
Sorry for the confusion.

Regards,
Steve