linux-kernel - Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqKoiaUmVhbQdnNveG=AAYh4-OHGS70L+LAgLLoKChUuYQ@mail.gmail.com>
Date:	Tue, 20 Jan 2015 11:29:16 -0600
From:	Rob Herring <robherring2@...il.com>
To:	Jacek Anaszewski <j.anaszewski@...sung.com>
Cc:	linux-leds@...r.kernel.org,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Pavel Machek <pavel@....cz>, Bryan Wu <cooloney@...il.com>,
	Richard Purdie <rpurdie@...ys.net>, sakari.ailus@....fi,
	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

On Tue, Jan 20, 2015 at 10:09 AM, Jacek Anaszewski
<j.anaszewski@...sung.com> wrote:
> On 01/16/2015 04:52 PM, Jacek Anaszewski wrote:
>>
>> On 01/16/2015 02:48 PM, Rob Herring wrote:

[...]

>>> You may want to add something like led-output-cnt or led-driver-cnt in
>>> the parent so you know the max list size.
>>
>>
>> Why should we need this? The number of current outputs exposed by the
>> device is fixed and can be specified in a LED device bindings
>> documentation.
>>
>
> OK. The led-output-cnt property should be put in each sub-node, as the
> number of the current outputs each LED can be connected to is variable.

Sorry, I meant this for the parent node meaning how many outputs the
driver IC has. I did say maybe because you may always know this. It
can make it easier to allocate memory for led-sources knowing the max
size up front.

Rob

>
> New version:
>
>  Optional properties for child nodes:
> +led-sources-cnt : Number of device current outputs the LED is connected to.
> +- led-sources : List of device current outputs the LED is connected to. The
> +               outputs are identified by the numbers that must be defined
> +               in the LED device binding documentation.
>  - label : The label for this LED.  If omitted, the label is
>    taken from the node name (excluding the unit address).
>
> @@ -33,7 +47,9 @@ system-status {
>
>  camera-flash {
>         label = "Flash";
> +       led-sources-cnt = <2>;
> +       led-sources = <0>, <1>;
>         max-microamp = <50000>;
>         flash-max-microamp = <320000>;
>         flash-timeout-us = <500000>;
> -}
> +};
>
>
> --
> Best Regards,
> Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/