linux-kernel - Re: linux-next: Tree for Jan 20 -- Kernel panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4237741.ePaG0Gba6D@sifl>
Date:	Tue, 20 Jan 2015 12:39:08 -0500
From:	Paul Moore <pmoore@...hat.com>
To:	Sabrina Dubroca <sd@...asysnail.net>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-audit@...hat.com,
	viro@...iv.linux.org.uk, Richard Guy Briggs <rgb@...hat.com>
Subject: Re: linux-next: Tree for Jan 20 -- Kernel panic - Unable to mount root fs

On Tuesday, January 20, 2015 05:56:55 PM Sabrina Dubroca wrote:
> Hello,
> 
> Today's linux-next doesn't boot on my qemu VM:

...
 
> I bisected it down to:
> 
> 5dc5218840e1  fs: create proper filename objects using getname_kernel()
> 
> I reverted then reapplied each part of that patch.  It works if I
> leave out the hunk for do_path_lookup:
> 
> diff --git a/fs/namei.c b/fs/namei.c
> index eeb3b83661f8..c3d21b79090e 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -2001,9 +2001,15 @@ static int filename_lookup(int dfd, struct filename
> *name, static int do_path_lookup(int dfd, const char *name,
>  				unsigned int flags, struct nameidata *nd)
>  {
> -	struct filename filename = { .name = name };
> +	int retval;
> +	struct filename *filename;
> 
> -	return filename_lookup(dfd, &filename, flags, nd);
> +	filename = getname_kernel(name);
> +	if (unlikely(IS_ERR(filename)))
> +		return PTR_ERR(filename);
> +	retval = filename_lookup(dfd, filename, flags, nd);
> +	putname(filename);
> +	return retval;
>  }
> 
> I don't know what other info you may need.
> Full dmesg for the failed boot included below.

Thanks for testing this and reporting the problem, especially such a small 
bisection.  Unfortunately nothing is immediately obvious to me, would you mind 
sharing your kernel config so I can try to reproduce and debug the problem?

-Paul

-- 
paul moore
security @ redhat

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/