linux-kernel - Re: [PATCH v4 4/5] ARM: sunxi: dts: Add A10/A20 PS2 pin muxing options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150120200307.GW4367@lukather>
Date:	Tue, 20 Jan 2015 21:03:07 +0100
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Vishnu Patekar <vishnupatekar0510@...il.com>
Cc:	dmitry.torokhov@...il.com, hdegoede@...hat.com,
	ijc+devicetree@...lion.org.uk,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-sunxi@...glegroups.com, linux-input@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v4 4/5] ARM: sunxi: dts: Add A10/A20 PS2 pin muxing
 options

On Fri, Jan 16, 2015 at 07:33:40PM +0530, Vishnu Patekar wrote:
> Signed-off-by: VishnuPatekar <vishnupatekar0510@...il.com>
> ---
>  arch/arm/boot/dts/sun4i-a10.dtsi |   14 ++++++++++++++
>  arch/arm/boot/dts/sun7i-a20.dtsi |   14 ++++++++++++++
>  2 files changed, 28 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
> index 2c31242..8fade3e 100644
> --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> @@ -629,6 +629,20 @@
>  				allwinner,drive = <0>;
>  				allwinner,pull = <0>;
>  			};
> +
> +			ps20_pins_a: ps20@0 {
> +				allwinner,pins = "PI20", "PI21";
> +				allwinner,function = "ps2";
> +				allwinner,drive = <0>;
> +				allwinner,pull = <0>;
> +			};
> +
> +			ps21_pins_a: ps21@0 {
> +				allwinner,pins = "PH12", "PH13";
> +				allwinner,function = "ps2";
> +				allwinner,drive = <0>;
> +				allwinner,pull = <0>;
> +			};
>  		};
>  
>  		timer@...20c00 {
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index f35c691..f9dd274 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -866,6 +866,20 @@
>  				    allwinner,drive = <0>;
>  				    allwinner,pull = <0>;
>  			};
> +
> +			ps20_pins_a: ps20@0 {
> +				allwinner,pins = "PI20", "PI21";
> +				allwinner,function = "ps2";
> +				allwinner,drive = <0>;
> +				allwinner,pull = <0>;
> +			};
> +
> +			ps21_pins_a: ps21@0 {
> +				allwinner,pins = "PH12", "PH13";
> +				allwinner,function = "ps2";
> +				allwinner,drive = <0>;
> +				allwinner,pull = <0>;
> +			};
>  		};

Same thing here, we're using defines now for the values in ,drive and
,pull, please use them.

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)