linux-kernel - Re: [PATCH] blackfin: mach-common: ints-priority: Remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 Jan 2015 14:44:14 +0800
From:	Steven Miao <realmz6@...il.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Sonic Zhang <sonic.zhang@...log.com>,
	Jiri Kosina <jkosina@...e.cz>,
	Randy Dunlap <rdunlap@...radead.org>,
	Christoph Lameter <cl@...ux.com>,
	Masanari Iida <standby24x7@...il.com>,
	bfin <adi-buildroot-devel@...ts.sourceforge.net>,
	"open list:CAN NETWORK DRIVERS <linux-can@...r.kernel.org>, open
	list:NETWORKING DRIVERS <netdev@...r.kernel.org>, open list" 
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] blackfin: mach-common: ints-priority: Remove unused function

Hi Rickard,

On Sun, Jan 4, 2015 at 1:01 AM, Rickard Strandqvist
<rickard_strandqvist@...ctrumdigital.se> wrote:
> Remove the function bfin_sec_resume() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>  arch/blackfin/mach-common/ints-priority.c |    8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/arch/blackfin/mach-common/ints-priority.c b/arch/blackfin/mach-common/ints-priority.c
> index dd2af74..7236bdf 100644
> --- a/arch/blackfin/mach-common/ints-priority.c
> +++ b/arch/blackfin/mach-common/ints-priority.c
> @@ -429,14 +429,6 @@ static void init_software_driven_irq(void)
>         bfin_sec_enable_ssi(37);
>  }
>
> -void bfin_sec_resume(void)
> -{
> -       bfin_write_SEC_SCI(0, SEC_CCTL, SEC_CCTL_RESET);
> -       udelay(100);
> -       bfin_write_SEC_GCTL(SEC_GCTL_EN);
> -       bfin_write_SEC_SCI(0, SEC_CCTL, SEC_CCTL_EN | SEC_CCTL_NMI_EN);
> -}
> -
>  void handle_sec_sfi_fault(uint32_t gstat)
>  {
>
> --
> 1.7.10.4
>
Yes, this bfin_sec_resume() should be dropped.

-steven
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/