linux-kernel - Re: [PATCH] power: max77693: fix simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <1421827163.4420.4.camel@AMDC1943>
Date:	Wed, 21 Jan 2015 08:59:23 +0100
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	kbuild test robot <fengguang.wu@...el.com>
Cc:	kbuild-all@...org, Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: max77693: fix simple_return.cocci warnings

On śro, 2015-01-21 at 12:11 +0800, kbuild test robot wrote:
> drivers/power/max77693_charger.c:615:1-4: WARNING: end returns can be simpified
> 
>  Simplify a trivial if-return sequence.  Possibly combine with a
>  preceding function call.
> Generated by: scripts/coccinelle/misc/simple_return.cocci
> 
> CC: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
> 
>  max77693_charger.c |    6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

> 
> --- a/drivers/power/max77693_charger.c
> +++ b/drivers/power/max77693_charger.c
> @@ -612,12 +612,8 @@ static int max77693_reg_init(struct max7
>  	if (ret)
>  		return ret;
>  
> -	ret = max77693_set_charge_input_threshold_volt(chg,
> +	return max77693_set_charge_input_threshold_volt(chg,
>  			chg->charge_input_threshold_volt);
> -	if (ret)
> -		return ret;
> -
> -	return 0;
>  }
>  
>  #ifdef CONFIG_OF

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/