linux-kernel - Re: [patch 00/23] x86: Cleanup apic/ioapic/x2apic setup code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1501211031570.5526@nanos>
Date:	Wed, 21 Jan 2015 10:33:19 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Jiang Liu <jiang.liu@...ux.intel.com>
cc:	LKML <linux-kernel@...r.kernel.org>,
	Joerg Roedel <joro@...tes.org>, x86@...nel.org,
	Tony Luck <tony.luck@...el.com>, Borislav Petkov <bp@...en8.de>
Subject: Re: [patch 00/23] x86: Cleanup apic/ioapic/x2apic setup code

On Wed, 21 Jan 2015, Jiang Liu wrote:
> On 2015/1/16 19:05, Thomas Gleixner wrote:
> Hi Thomas,
> 	With above patch applied, it just gives a blank screen
> instead of a panic when booting on my problematic laptop.
> Now I have found the root cause of the failure on my laptop.
> 	On i386, it triggers  BUG_ON(!apic->apic_id_registered())
> in function setup_local_APIC() because apic_bsp_up_setup() is called
> too late. So we need a simple patch as below. With following patch
> applied, it boots successfully with your original patch.

Duh. Right you are. I wonder why this boots on any other
machine. Seems there is some more magic in this setup maze.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/