linux-kernel - Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <54BF73B9.8060402@samsung.com>
Date:	Wed, 21 Jan 2015 10:39:05 +0100
From:	Jacek Anaszewski <j.anaszewski@...sung.com>
To:	Pavel Machek <pavel@....cz>
Cc:	Rob Herring <robherring2@...il.com>, linux-leds@...r.kernel.org,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Bryan Wu <cooloney@...il.com>,
	Richard Purdie <rpurdie@...ys.net>, sakari.ailus@....fi,
	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

On 01/20/2015 06:40 PM, Pavel Machek wrote:
> On Tue 2015-01-20 11:29:16, Rob Herring wrote:
>> On Tue, Jan 20, 2015 at 10:09 AM, Jacek Anaszewski
>> <j.anaszewski@...sung.com> wrote:
>>> On 01/16/2015 04:52 PM, Jacek Anaszewski wrote:
>>>>
>>>> On 01/16/2015 02:48 PM, Rob Herring wrote:
>>
>> [...]
>>
>>>>> You may want to add something like led-output-cnt or led-driver-cnt in
>>>>> the parent so you know the max list size.
>>>>
>>>>
>>>> Why should we need this? The number of current outputs exposed by the
>>>> device is fixed and can be specified in a LED device bindings
>>>> documentation.
>>>>
>>>
>>> OK. The led-output-cnt property should be put in each sub-node, as the
>>> number of the current outputs each LED can be connected to is variable.
>>
>> Sorry, I meant this for the parent node meaning how many outputs the
>> driver IC has. I did say maybe because you may always know this. It
>> can make it easier to allocate memory for led-sources knowing the max
>> size up front.
>
> Umm. Not sure if that kind of "help" should go to the device
> tree.
> 									Pavel
>

I agree. I think that led-sources-cnt is redundant. A list property
can be read using of_prop_next_u32 function. I missed that and thus
proposed putting led-sources-cnt in each sub-node to be able to read 
led-sources list with of_property_read_u32_array.

Effectively, I propose to avoid adding led-sources-cnt property.

-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/