linux-kernel - Re: [PATCH 1/2] staging: emxx_udc: Replace ERR by dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150121124655.GB4493@hudson.localdomain>
Date:	Wed, 21 Jan 2015 04:46:55 -0800
From:	Jeremiah Mahler <jmmahler@...il.com>
To:	Ahmad Hassan <ahmad.hassan612@...il.com>
Cc:	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	vinc94@...il.com, roberta.dobrescu@...il.com,
	sachin.kamat@...sung.com, ebru.akagunduz@...il.com,
	damm+renesas@...nsource.se, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: emxx_udc: Replace ERR by dev_err

Ahmad,

On Wed, Jan 21, 2015 at 01:55:11PM -0900, Ahmad Hassan wrote:
[...]
>  	if (udc == NULL) {
> -		ERR("%s udc == NULL\n", __func__);
> +		dev_err(udc->dev,"%s udc == NULL\n", __func__);
                      ^^^^^

Always check your patches with checkpatch.pl before submitting them.

There are a bunch of "space required after ','" errors in this patch.

-- 
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/