linux-kernel - Re: [PATCH] ti-soc-thermal: implement eocz bit to make driver useful on omap3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150121052156.GB13468@developer.hsd1.ca.comcast.net>
Date:	Wed, 21 Jan 2015 01:21:57 -0400
From:	Eduardo Valentin <edubezval@...il.com>
To:	Pavel Machek <pavel@....cz>
Cc:	pali.rohar@...il.com, sre@...ian.org, sre@...g0.de,
	kernel list <linux-kernel@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	linux-omap@...r.kernel.org, tony@...mide.com, khilman@...nel.org,
	aaro.koskinen@....fi, ivo.g.dimitrov.75@...il.com,
	rui.zhang@...el.com, linux-pm@...r.kernel.org
Subject: Re: [PATCH] ti-soc-thermal: implement eocz bit to make driver useful
 on omap3

On Sun, Jan 18, 2015 at 09:18:21PM +0100, Pavel Machek wrote:
> Hi!
> 
> > > Ok, what do you suggest? AFAICT, without MODE_CONFIG, continuous ADC
> > > mode is not available, so we have to force it periodically, so this
> > > should be correct.
> > 
> > I will have a better look and let you know. for now, adding a single
> > read should not hurt ( but I will double check)
> 
> Any news there?

I believe it is OK to keep your code the way you posted.

Thanks.

> 
> > > > > +		if (ret)
> > > > > +			return ret;
> > > > > +	}
> > > > > +
> > > > >  	spin_lock(&bgp->lock);
> > > > >  	temp = ti_bandgap_read_temp(bgp, id);
> > > > >  	spin_unlock(&bgp->lock);
> > > > >  
> > > > > -	ret |= ti_bandgap_adc_to_mcelsius(bgp, temp, &temp);
> > > > > +	ret = ti_bandgap_adc_to_mcelsius(bgp, temp, &temp);
> > > > 
> > > > this one should be part of your clean up patch
> > > 
> > > Ok, can you apply the cleanup patch and I'll prepare one on the top of
> > > it?
> > 
> > I mean, you should resend the cleanup patch including the above '|=' removal, as you are already doing in the cleanup patch.
> > 
> 
> Ok, little patch-editing can not hurt :-).
> 
> 									Pavel
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)