linux-kernel - Re: [PATCH v6 0/7] Add initial support for DA9150 Charger & Fuel-Gauge IC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150121165250.GG13715@earth.universe>
Date:	Wed, 21 Jan 2015 17:52:50 +0100
From:	Sebastian Reichel <sre@...nel.org>
To:	Adam Thomson <Adam.Thomson.Opensource@...semi.com>,
	Lee Jones <lee.jones@...aro.org>,
	Jonathan Cameron <jic23@...nel.org>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Hartmut Knaack <knaack.h@....de>, linux-iio@...r.kernel.org,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	linux-pm@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Grant Likely <grant.likely@...aro.org>,
	devicetree@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Joe Perches <joe@...ches.com>, linux-kernel@...r.kernel.org,
	support.opensource@...semi.com
Subject: Re: [PATCH v6 0/7] Add initial support for DA9150 Charger &
 Fuel-Gauge IC

Hi,

On Wed, Jan 21, 2015 at 03:46:25PM +0000, Adam Thomson wrote:
> This patch set adds initial support for the Dialog DA9150 Integrated Charger &
> Fuel-Gauge IC. The device also provides GPIO and GPADC functionality.
> 
> In this patch set the following is provided:
>  - MFD Core support and DT bindings documentation.
>  - IIO GPADC support and DT bindings documentation.
>  - Power Supply Charger support and DT bindings documentation.
>  - Update to MAINTAINERS file to add DA9150 files to Dialog support list.
> 
> To keep patch submission from being too large, support for GPIO and Fuel-Gauge
> will come after initial support patches are accepted.
> 
> This patch set is baselined against the v3.19-rc5 kernel version.
> 
> Changes in v6:
> - For GPADC driver, Use lower case extended names for IIO GPADC channels, and
>   remove extended names for GPIO related channels.
> - For charger driver, revert to no devm IRQ request/free functions as ordering
>   is important, and probe failure scenario was not being correctly covered. A
>   helper function for free IRQs has been added to make code cleaner.

Probably a devm_ variant of power_supply_register should be created,
but for now this is ok for me.

Jonathan, Lee: I assume you are ok with the whole patchset going
through the power supply subsystem?

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)