linux-kernel - Re: [PATCH v2] drm/i2c: tda998x: Set the CEC I2C address based on the slave I2C address.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150121184405.GI10762@e106497-lin.cambridge.arm.com>
Date:	Wed, 21 Jan 2015 18:44:05 +0000
From:	Liviu Dudau <Liviu.Dudau@....com>
To:	Andrew Jackson <Andrew.Jackson@....com>
Cc:	Russell King - ARM Linux <linux@....linux.org.uk>,
	"airlied@...ux.ie" <airlied@...ux.ie>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"moinejf@...e.fr" <moinejf@...e.fr>
Subject: Re: [PATCH v2] drm/i2c: tda998x: Set the CEC I2C address based on
 the slave I2C address.

On Fri, Nov 07, 2014 at 08:31:25AM +0000, Andrew Jackson wrote:
> The I2C address for the TDA9989 and TDA19989 is fixed at 0x34
> but the two LSBs of the TDA19988's address are set by two configuration
> pins on the chip.  Irrespective of the chip, the associated CEC
> peripheral's I2C address is based upon the main I2C address.
> 
> This patch avoids any special handling required to support
> systems that contain multiple TDA19988 devices on the same
> I2C bus.
> 
> Signed-off-by: Andrew Jackson <Andrew.Jackson@....com>
> Signed-off-by: Liviu Dudau <Liviu.Dudau@....com>

Hi Andrew,

What is the status of this patch? Is it going to be pulled by anyone?

Best regards,
Liviu

> ---
>  drivers/gpu/drm/i2c/tda998x_drv.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
> index d476279..eeab17a 100644
> --- a/drivers/gpu/drm/i2c/tda998x_drv.c
> +++ b/drivers/gpu/drm/i2c/tda998x_drv.c
> @@ -1255,6 +1255,7 @@ static int tda998x_create(struct i2c_client *client, struct tda998x_priv *priv)
>  	struct device_node *np = client->dev.of_node;
>  	u32 video;
>  	int rev_lo, rev_hi, ret;
> +	unsigned short cec_addr;
>  
>  	priv->vip_cntrl_0 = VIP_CNTRL_0_SWAP_A(2) | VIP_CNTRL_0_SWAP_B(3);
>  	priv->vip_cntrl_1 = VIP_CNTRL_1_SWAP_C(0) | VIP_CNTRL_1_SWAP_D(1);
> @@ -1262,7 +1263,9 @@ static int tda998x_create(struct i2c_client *client, struct tda998x_priv *priv)
>  
>  	priv->current_page = 0xff;
>  	priv->hdmi = client;
> -	priv->cec = i2c_new_dummy(client->adapter, 0x34);
> +	/* CEC I2C address bound to TDA998x I2C addr by configuration pins */
> +	cec_addr = 0x34 + (client->addr & 0x03);
> +	priv->cec = i2c_new_dummy(client->adapter, cec_addr);
>  	if (!priv->cec)
>  		return -ENODEV;
>  
> -- 
> 1.7.1
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/