linux-kernel - Re: [PATCH V3 02/11] power: charger-manager: Use thermal subsystem interface only to get temperature.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150121223848.GI13715@earth.universe>
Date:	Wed, 21 Jan 2015 23:38:48 +0100
From:	Sebastian Reichel <sre@...nel.org>
To:	Jonghwa Lee <jonghwa3.lee@...sung.com>
Cc:	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	dbaryshkov@...il.com, dwmw2@...radead.org, anton@...msg.org,
	pavel@....cz, myungjoo.ham@...sung.com, cw00.choi@...sung.com
Subject: Re: [PATCH V3 02/11] power: charger-manager: Use thermal subsystem
 interface only to get temperature.

Hi Jonghwa,

On Fri, Dec 19, 2014 at 05:55:14PM +0900, Jonghwa Lee wrote:
> It drops the way of using power_supply interface to reference battery's
> temperature. Then it tries to use thermal subsystem's only. This makes driver
> more simple and also can remove ifdeferies.

this breaks allmodconfig, since CONFIG_THERMAL can be built as
module and charger-manager will be builtin:

drivers/built-in.o: In function `cm_get_battery_temperature.isra.4':
binder.c:(.text+0x2f4008): undefined reference to `thermal_zone_get_temp'
drivers/built-in.o: In function `charger_manager_probe':
binder.c:(.text+0x2f62c4): undefined reference to `thermal_zone_get_zone_by_name'
Makefile:917: recipe for target 'vmlinux' failed

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)