linux-kernel - Re: gpio-sx150x.c build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAVeFuJgG=wng_RAE76z-1BdNN-mzyuEbhmCk7_2XGv=9kkEng@mail.gmail.com>
Date:	Thu, 22 Jan 2015 12:02:39 +0900
From:	Alexandre Courbot <gnurou@...il.com>
To:	Mike Krinkin <krinkin.m.u@...il.com>, Wei Chen <Wei.Chen@....com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: gpio-sx150x.c build error

On Wed, Jan 21, 2015 at 6:29 PM, Mike Krinkin <krinkin.m.u@...il.com> wrote:
> Hello,
>
> i failed to build linux-next for 20 Jan, because of the following build error:
>
> drivers/gpio/gpio-sx150x.c:487:17: error: ‘struct gpio_chip’ has no member named ‘of_node’
>   chip->gpio_chip.of_node          = client->dev.of_node;
>                  ^
> drivers/gpio/gpio-sx150x.c:488:17: error: ‘struct gpio_chip’ has no member named ‘of_gpio_n_cells’
>   chip->gpio_chip.of_gpio_n_cells  = 2;
>                  ^
> make[2]: *** [drivers/gpio/gpio-sx150x.o] Error 1
> make[1]: *** [drivers/gpio] Error 2
> make: *** [drivers] Error 2
>
> This change introduced by Wei Chen commit 04d2264c3bf0 ("gpio: sx150x: add dts
> support for sx150x driver"). Maybe `#ifndef CONFIG_OF_GPIO` should be here?
>
> FIY: i don't use this gpio, just happened to notice, and i have disabled this
> in my config.

Adding Wei. Could you have a look at this and send a fixup patch?

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/