lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Jan 2015 11:48:17 +0800 From: Caesar Wang <sasukewxt@....com> To: Mark Yao <mark.yao@...k-chips.com>, David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>, Rob Clark <robdclark@...il.com>, Philipp Zabel <p.zabel@...gutronix.de>, Daniel Kurtz <djkurtz@...omium.org>, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org Subject: Re: [PATCH] drm/rockchip: vop: fix vop vsync/hsync polarity Mark, 在 2015年01月22日 11:15, Mark Yao 写道: > Vop set wrong vsync/hsync polarity, it may cause some > display problem. known problem is that caused HDMI hdcp > authenticate failed, caused pixel offset with hdmi display. > the polarity description at RK3288 TRM doc: > dsp_vsync_pol > VSYNC polarity > 1'b0 : negative > 1'b1 : positive > dsp_hsync_pol > HSYNC polarity > 1'b0 : negative > 1'b1 : positive > > Signed-off-by: Mark Yao <mark.yao@...k-chips.com> > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index 9a5c571..2b145ba5 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -874,8 +874,8 @@ static int vop_crtc_mode_set(struct drm_crtc *crtc, > VOP_CTRL_SET(vop, out_mode, vop->connector_out_mode); > > val = 0x8; > - val |= (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC) ? 1 : 0; > - val |= (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC) ? (1 << 1) : 0; > + val |= (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC) ? 0 : 1; > + val |= (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC) ? 0 : (1 << 1); Tested-by: Caesar Wang <wxt@...k-chips.com> > VOP_CTRL_SET(vop, pin_pol, val); > > VOP_CTRL_SET(vop, htotal_pw, (htotal << 16) | hsync_len); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists