linux-kernel - Re: [PATCH v3 1/2] power: rt5033_charger: Add RT5033 charger device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 22 Jan 2015 12:59:12 +0900
From:	Beomho Seo <beomho.seo@...sung.com>
To:	Sebastian Reichel <sre@...nel.org>
Cc:	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	devicetree@...r.kernel.org, robh+dt@...nel.org,
	lee.jone@...aro.org, broonie@...nel.org, dbaryshkov@...il.com,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	cw00.choi@...sung.com, inki.dae@...sung.com,
	sw0312.kim@...sung.com, David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH v3 1/2] power: rt5033_charger: Add RT5033 charger device
 driver

Thank you for review.

On 01/22/2015 12:12 PM, Sebastian Reichel wrote:
> Hi,
> 
> On Thu, Jan 22, 2015 at 09:38:11AM +0900, Beomho Seo wrote:
>> This patch add device driver of Richtek RT5033 PMIC. The driver
>> support switching charger. rt5033 charger provide three charging
>> mode.  Three charging mode are pre charge mode, fast cahrge mode
>> and constant voltage mode. They are have vary charge rate, charge
>> parameters. The charge parameters can be controlled by i2c
>> interface.
>>
>> [...]
>>
>> +	charger->psy.name = "rt5033-charger",
>> +	charger->psy.type = POWER_SUPPLY_TYPE_BATTERY,
>>
>> [...]
> 
> POWER_SUPPLY_TYPE_MAINS?
> 
> -- Sebastian
> 

OK I will change power supply type.

Thanks,
Beomho Seo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/