linux-kernel - Re: [rtc-linux] [PATCH] rtc: s5m: terminate s5m_rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJKOXPfuxD91=hEYoTQ2Vdes+cf-FXGUZRD2HUbeNzS3czKobA@mail.gmail.com>
Date:	Thu, 22 Jan 2015 10:37:25 +0100
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	rtc-linux@...glegroups.com
Cc:	linux-kernel@...r.kernel.org,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Andrey Ryabinin <a.ryabinin@...sung.com>
Subject: Re: [rtc-linux] [PATCH] rtc: s5m: terminate s5m_rtc_id array with
 empty element

2015-01-21 16:06 GMT+01:00 Andrey Ryabinin <a.ryabinin@...sung.com>:
> Array of platform_device_id elements should be terminated
> with empty element.
>
> Signed-off-by: Andrey Ryabinin <a.ryabinin@...sung.com>
> ---
>  drivers/rtc/rtc-s5m.c | 1 +
>  1 file changed, 1 insertion(+)


Right, good catch.

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

Maybe also cc stable for fixing 5bccae6ec458 ("rtc: s5m-rtc: add
real-time clock driver for s5m8767")?

Best regards,
Krzysztof

>
> diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c
> index b5e7c46..89ac1d5 100644
> --- a/drivers/rtc/rtc-s5m.c
> +++ b/drivers/rtc/rtc-s5m.c
> @@ -832,6 +832,7 @@ static SIMPLE_DEV_PM_OPS(s5m_rtc_pm_ops, s5m_rtc_suspend, s5m_rtc_resume);
>  static const struct platform_device_id s5m_rtc_id[] = {
>         { "s5m-rtc",            S5M8767X },
>         { "s2mps14-rtc",        S2MPS14X },
> +       { },
>  };
>
>  static struct platform_driver s5m_rtc_driver = {
> --
> 2.2.1
>
> --
> --
> You received this message because you are subscribed to "rtc-linux".
> Membership options at http://groups.google.com/group/rtc-linux .
> Please read http://groups.google.com/group/rtc-linux/web/checklist
> before submitting a driver.
> ---
> You received this message because you are subscribed to the Google Groups "rtc-linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@...glegroups.com.
> For more options, visit https://groups.google.com/d/optout.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/