linux-kernel - Re: [PATCH RESEND v2 3/7] mfd: cros_ec: Add cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54C0D29C.4010904@collabora.co.uk>
Date:	Thu, 22 Jan 2015 11:36:12 +0100
From:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
To:	Lee Jones <lee.jones@...aro.org>
CC:	Olof Johansson <olof@...om.net>,
	Doug Anderson <dianders@...omium.org>,
	Bill Richardson <wfrichar@...omium.org>,
	Simon Glass <sjg@...gle.com>,
	Gwendal Grignou <gwendal@...gle.com>,
	Jonathan Corbet <corbet@....net>,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	arnd@...db.de
Subject: Re: [PATCH RESEND v2 3/7] mfd: cros_ec: Add cros_ec_lpc driver for
 x86 devices

Hello Lee,

On 01/22/2015 10:46 AM, Lee Jones wrote:
>> 
>> But there doesn't seem to be a LPC subsystem in the kernel so we don't have a
>> nice abstraction layer in this case.
> 
> This is the crux of the problem.  However, I feel bad for MFD, as it
> is, once more, being used as an "well it doesn't fit anywhere else, so
> let's shoehorn it in there" type of dumping ground.
>

Yes, I completely understand your point, is that I didn't think that a ~300
lines driver was that bad specially since the communication bits that reads
and writes the register is not a complex logic IMHO.
 
>> > Are there any other Low Pin Count drivers in the kernel?
>> >
>> 
>> I don't know tbh, I didn't even know what LPC was before I picked this patch
>> to push it upstream. I searched in the Linux codebase for other LPC drivers
>> but I didn't find anything, that doesn't mean that it doesn't exist though.
> 
> I agree.  Perhaps a suitable driver should live in drivers/misc until
> there are enough of them to warrant its own subsystem.
>

Yes, I can move the driver to drivers/misc if you think that is more suitable
to be there.

I've taken another look and AFAICT there are two other mfd drivers that use an
LPC bus, these are drivers/mfd/lpc_{i,s}ch.c for Intel's I/O Controller HUB and 
System Controller Hub respectively.

> Anyone else have an opinion?
> 

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/