linux-kernel - Re: [PATCH] scsi_debug: test always evaluates to false, || should be used instead

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54C0DF95.8000103@interlog.com>
Date:	Thu, 22 Jan 2015 12:31:33 +0100
From:	Douglas Gilbert <dgilbert@...erlog.com>
To:	Colin King <colin.king@...onical.com>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	linux-scsi@...r.kernel.org
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi_debug: test always evaluates to false, || should
 be used instead

On 15-01-22 12:20 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> cppcheck found the following issue:
> (warning) Logical conjunction always evaluates to false:
>    alloc_len < 4 && alloc_len > 65535.
>
> ..the test should be instead:
>
>    if (alloc_len < 4 || alloc_len > 65536)
>
> This error was introduced by recent commit 38d5c8336e60bf6e53a1da9
> ("scsi_debug: add Report supported opcodes+tmfs; Compare and write")
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>   drivers/scsi/scsi_debug.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
> index 7b8b51b..63a2e1f 100644
> --- a/drivers/scsi/scsi_debug.c
> +++ b/drivers/scsi/scsi_debug.c
> @@ -1623,7 +1623,7 @@ resp_rsup_opcodes(struct scsi_cmnd *scp, struct sdebug_dev_info *devip)
>   	req_opcode = cmd[3];
>   	req_sa = get_unaligned_be16(cmd + 4);
>   	alloc_len = get_unaligned_be32(cmd + 6);
> -	if (alloc_len < 4 && alloc_len > 0xffff) {
> +	if (alloc_len < 4 || alloc_len > 0xffff) {
>   		mk_sense_invalid_fld(scp, SDEB_IN_CDB, 6, -1);
>   		return check_condition_result;
>   	}
>

I have presented this fix twice already. Most recently in
"[PATCH] [RESEND] scsi_debug: fix sanity check in resp_rsup_opcodes"
20150102. So one more time, with feeling:

Acked-by: Douglas Gilbert <dgilbert@...erlog.com>




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/