linux-kernel - Re: [PATCH] i2c-ocores: add common clock support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150122144522.GF3413@katana>
Date:	Thu, 22 Jan 2015 15:45:22 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Max Filippov <jcmvbkbc@...il.com>
Cc:	Peter Korsgaard <jacmet@...site.dk>, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c-ocores: add common clock support

> @@ -320,9 +322,23 @@ static int ocores_i2c_of_probe(struct platform_device *pdev,
>  	}
>  
>  	if (of_property_read_u32(np, "clock-frequency", &val)) {
> -		dev_err(&pdev->dev,
> -			"Missing required parameter 'clock-frequency'\n");
> -		return -ENODEV;
> +		struct clk *clk = devm_clk_get(&pdev->dev, NULL);
> +
> +		if (!IS_ERR(clk)) {
> +			int ret = clk_prepare_enable(clk);
> +
> +			if (ret) {
> +				dev_err(&pdev->dev,
> +					"clk_prepare_enable failed: %d\n", ret);
> +				return ret;
> +			}
> +			i2c->clk = clk;
> +			val = clk_get_rate(clk);
> +		} else {
> +			dev_err(&pdev->dev,
> +				"Missing required parameter 'clock-frequency'\n");
> +			return -ENODEV;
> +		}

Either NAK or I don't understand the logic here :) If a dts does NOT
have the bus-speed set by 'clock-frequency', then we take the value of
the clock assigned to this platform_device?

The usual thing to do when 'clock-frequency' is not set is to default to
100kHz.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)