lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Jan 2015 15:03:44 -0600 From: Bjorn Helgaas <bhelgaas@...gle.com> To: Rob Herring <robh@...nel.org> Cc: linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>, linux-pci@...r.kernel.org, Alexandre Courbot <gnurou@...il.com>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, David Howells <dhowells@...hat.com>, Greg Ungerer <gerg@...inux.org>, Koichi Yasutake <yasutake.koichi@...panasonic.com>, Krzysztof Halasa <khalasa@...p.pl>, Linus Walleij <linus.walleij@...aro.org>, Michael Ellerman <mpe@...erman.id.au>, Michal Simek <michal.simek@...inx.com>, Paul Mackerras <paulus@...ba.org>, Ralf Baechle <ralf@...ux-mips.org>, Russell King <linux@....linux.org.uk>, Simon Horman <horms@...ge.net.au>, Sören Brinkmann <soren.brinkmann@...inx.com>, Stephen Warren <swarren@...dotorg.org>, Tanmay Inamdar <tinamdar@....com>, Thierry Reding <thierry.reding@...il.com>, Will Deacon <will.deacon@....com>, cbe-oss-dev@...ts.ozlabs.org, linux-am33-list@...hat.com, linux-arm-kernel@...ts.infradead.org, linux-mips@...ux-mips.org, linuxppc-dev@...ts.ozlabs.org, linux-sh@...r.kernel.org, linux-tegra@...r.kernel.org Subject: Re: [PATCH 00/16] PCI generic configuration space accessors On Fri, Jan 09, 2015 at 08:34:34PM -0600, Rob Herring wrote: > This series adds common accessor functions for PCI configuration space > accesses. This supports most PCI hosts with memory mapped configuration > space like ECAM or hosts with memory mapped address/data registers. ECAM > is not generically supported by this series, but could be added on top > of this. While some hosts have standard address decoding which could be > common as well, the various checks on bus numbers and device numbers are > quite varied. It is unclear how much of that is really necessary or > could be common. > > The first 4 patches are preparatory cleanup. Patch 5 introduces the > common accessors. The remaining patches convert several PCI host > controllers. This is in no way a complete list of host controllers. The > conversion of more hosts should be possible. The Designware controller > in particular should be able to be converted, but its config space > accessors are a mess of override-able functions that I've not gotten my > head around. > > This series is available here [1]. > > Rob > > [1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git pci-config-access > > Rob Herring (16): > frv: add struct pci_ops member names to initialization > mips: add struct pci_ops member names to initialization > mn10300: add struct pci_ops member names to initialization > powerpc: add struct pci_ops member names to initialization > pci: introduce common pci config space accessors > ARM: cns3xxx: convert PCI to use generic config accesses > ARM: integrator: convert PCI to use generic config accesses > ARM: sa1100: convert PCI to use generic config accesses > ARM: ks8695: convert PCI to use generic config accesses > powerpc: fsl_pci: convert PCI to use generic config accesses > powerpc: powermac: convert PCI to use generic config accesses > pci/host: generic: convert to use generic config accesses > pci/host: rcar-gen2: convert to use generic config accesses > pci/host: tegra: convert to use generic config accesses > pci/host: xgene: convert to use generic config accesses > pci/host: xilinx: convert to use generic config accesses > > arch/arm/mach-cns3xxx/pcie.c | 52 ++---- > arch/arm/mach-integrator/pci_v3.c | 61 +------- > arch/arm/mach-ks8695/pci.c | 77 +-------- > arch/arm/mach-sa1100/pci-nanoengine.c | 94 +---------- > arch/frv/mb93090-mb00/pci-vdk.c | 4 +- > arch/mips/pci/pci-bcm1480.c | 4 +- > arch/mips/pci/pci-octeon.c | 4 +- > arch/mips/pci/pcie-octeon.c | 12 +- > arch/mn10300/unit-asb2305/pci.c | 4 +- > arch/powerpc/platforms/cell/celleb_scc_pciex.c | 4 +- > arch/powerpc/platforms/powermac/pci.c | 209 +++++-------------------- > arch/powerpc/sysdev/fsl_pci.c | 46 +----- > drivers/pci/access.c | 87 ++++++++++ > drivers/pci/host/pci-host-generic.c | 51 +----- > drivers/pci/host/pci-rcar-gen2.c | 51 +----- > drivers/pci/host/pci-tegra.c | 55 +------ > drivers/pci/host/pci-xgene.c | 150 ++---------------- > drivers/pci/host/pcie-xilinx.c | 88 ++--------- > include/linux/pci.h | 11 ++ > 19 files changed, 212 insertions(+), 852 deletions(-) Really nice cleanups. I added these with the acks so far to a pci/config branch for v3.20. I'll update it with more acks if they trickle in. You've structured it nicely so I can also just drop individual arch pieces if necessary. The pieces that haven't been acked yet (hint, hint): arch/arm/mach-cns3xxx/pcie.c arch/arm/mach-sa1100/pci-nanoengine.c arch/mn10300/unit-asb2305/pci.c arch/powerpc In addition, nobody has acked the frv and mips parts, but they're trivial (they only add struct member names) that I can apply them without worrying. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists