linux-kernel - Re: [PATCH] sched-rt: Reduce excessive task push rate by not pushing tasks with equal priority as the current task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1421987370.5280.21.camel@marge.simpson.net>
Date:	Fri, 23 Jan 2015 05:29:30 +0100
From:	Mike Galbraith <umgwanakikbuti@...il.com>
To:	Tim Chen <tim.c.chen@...ux.intel.com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Andi Kleen <andi@...stfloor.org>, Ingo Molnar <mingo@...e.hu>,
	Shawn Bohrer <sbohrer@...advisors.com>,
	Suruchi Kadu <suruchi.a.kadu@...el.com>,
	Doug Nelson <doug.nelson@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched-rt: Reduce excessive task push rate by not
 pushing tasks with equal priority as the current task

On Thu, 2015-01-22 at 10:53 -0800, Tim Chen wrote: 
> Commit 3be209a8 tries to migrate task of equal priority as the running
> one to other cpus to balance load and eliminate any idle cpus.  However,
> for system that is fully busy and running workload of a few priorities,
> we found this change to cause tasks getting pushed around without
> improving cpu utilization. On a fully loaded system running a well known
> OLTP benchmark, it causes 70% more run queue locking in the push task
> path without improving cpu utilization and make throughput degrade by
> 1.5%. We observe much higher rq lock contention due to excessive lockings
> of target run queues on task wakeup.

Pushing tasks of equal priority is about getting rt tasks to a CPU they
can utilize NOW.  Trying to improve throughput and whatnot is all well
and good, but sacrificing the most sacred rt cow on the planet to
improve some benchmark number is a very bad idea :)

-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/