linux-kernel - Re: [PATCH v2 4/9] ARM: STi: DT: STiH407: Add Device Tree node for the LPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54C208D9.6050006@st.com>
Date:	Fri, 23 Jan 2015 09:39:53 +0100
From:	David Paris <david.paris@...com>
To:	Lee Jones <lee.jones@...aro.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Cc:	<kernel@...inux.com>, <rtc-linux@...glegroups.com>,
	<wim@...ana.be>, <linux-watchdog@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux@...ck-us.net>
Subject: Re: [PATCH v2 4/9] ARM: STi: DT: STiH407: Add Device Tree node for
 the LPC

Hi Lee,

     Just a minor remark/question,

     David

On 01/22/2015 12:56 PM, Lee Jones wrote:
> On current ST platforms the LPC controls a number of functions.  This
> patch enables support for the LPC Watchdog and LPC RTC devices on LPC1
> and LPC2 respectively.
>
> Signed-off-by: David Paris <david.paris@...com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>   arch/arm/boot/dts/stih407-family.dtsi | 20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
> index 3e31d32..04448a7 100644
> --- a/arch/arm/boot/dts/stih407-family.dtsi
> +++ b/arch/arm/boot/dts/stih407-family.dtsi
> @@ -7,6 +7,7 @@
>    * publishhed by the Free Software Foundation.
>    */
>   #include "stih407-pinctrl.dtsi"
> +#include <dt-bindings/mfd/st-lpc.h>
>   #include <dt-bindings/reset-controller/stih407-resets.h>
>   / {
>   	#address-cells = <1>;
> @@ -274,5 +275,24 @@
>   
>   			status = "disabled";
>   		};
> +
> +		/* Watchdog and Real-Time Clock */
> +		lpc@...7000 {
> +			compatible = "st,stih407-lpc";
> +			reg = <0x8787000 0x1000>;
> +			interrupts = <GIC_SPI 129 IRQ_TYPE_EDGE_RISING>;
In case of Watchdog, "interrupt" property is not used. So I think we can 
remove it ?
> +			clocks = <&clk_s_d3_flexgen CLK_LPC_0>;
> +			timeout-sec = <120>;
> +			st,syscfg = <&syscfg_core>;
> +			st,lpc-mode = <ST_LPC_MODE_WDT>;
> +		};
> +
> +		lpc@...8000 {
> +			compatible = "st,stih407-lpc";
> +			reg = <0x8788000 0x1000>;
> +			interrupts = <GIC_SPI 130 IRQ_TYPE_EDGE_RISING>;
> +			clocks = <&clk_s_d3_flexgen CLK_LPC_1>;
> +			st,lpc-mode = <ST_LPC_MODE_RTC>;
> +		};
>   	};
>   };

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/