linux-kernel - Re: [PATCH v2] i2c: tegra: Maintain CPU endianness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAVeFuLLn8L0s7_19TX+RzSY88T0tno4SRguM2ipBe6yWHrgmw@mail.gmail.com>
Date:	Fri, 23 Jan 2015 18:10:58 +0900
From:	Alexandre Courbot <gnurou@...il.com>
To:	Dmitry Osipenko <digetx@...il.com>
Cc:	Wolfram Sang <wsa@...-dreams.de>,
	Stephen Warren <swarren@...dotorg.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Laxman Dewangan <ldewangan@...dia.com>,
	Ben Dooks <ben.dooks@...ethink.co.uk>,
	Bob Mottram <bob.mottram@...ethink.co.uk>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] i2c: tegra: Maintain CPU endianness

On Fri, Jan 23, 2015 at 3:12 AM, Dmitry Osipenko <digetx@...il.com> wrote:
> Support CPU BE mode by adding endianness conversion for memcpy interactions.
>
> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> ---
> Changelog:
> v2: For consistency cpu_to_le32() changed to le32_to_cpu() because
>     i2c_writel() takes BE value in BE CPU mode and value is in LE format.
>
>  drivers/i2c/busses/i2c-tegra.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
> index 28b87e6..b5afb9f 100644
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++ b/drivers/i2c/busses/i2c-tegra.c
> @@ -286,6 +286,7 @@ static int tegra_i2c_empty_rx_fifo(struct tegra_i2c_dev *i2c_dev)
>         if (rx_fifo_avail > 0 && buf_remaining > 0) {
>                 BUG_ON(buf_remaining > 3);
>                 val = i2c_readl(i2c_dev, I2C_RX_FIFO);
> +               val = cpu_to_le32(val);
>                 memcpy(buf, &val, buf_remaining);
>                 buf_remaining = 0;
>                 rx_fifo_avail--;
> @@ -343,7 +344,9 @@ static int tegra_i2c_fill_tx_fifo(struct tegra_i2c_dev *i2c_dev)
>          */
>         if (tx_fifo_avail > 0 && buf_remaining > 0) {
>                 BUG_ON(buf_remaining > 3);
> +               val = 0;
>                 memcpy(&val, buf, buf_remaining);
> +               val = le32_to_cpu(val);

Ok, with le32_to_cpu() this makes sense now. memcpying part of an int
will keep the lowest byte at the lowest address, so this should work
for little-endian.

Acked-by: Alexandre Courbot <acourbot@...dia.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/