linux-kernel - Re: [PATCH] net: ieee802154: cc2520: fix coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP8vtK+UQZ=fNZPeOFc-7zLNhcUDTRfbUa-JQQ70x6A8q=Xi7A@mail.gmail.com>
Date:	Fri, 23 Jan 2015 15:18:31 +0530
From:	Jamal Mohammad <md.jamalmohiuddin@...il.com>
To:	Varka Bhadram <varkabhadram@...il.com>
Cc:	Alexander Aring <alex.aring@...il.com>,
	linux-wpan - ML <linux-wpan@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: ieee802154: cc2520: fix coding style issue

On Fri, Jan 23, 2015 at 3:16 PM, Varka Bhadram <varkabhadram@...il.com> wrote:
> Hi Mohammad Jamal,
>
> On Fri, Jan 23, 2015 at 3:06 PM, Mohammad Jamal
> <md.jamalmohiuddin@...il.com> wrote:
>> This patch solves the coding style issue warning
>> by replacing the shifting operations by BIT macro
>>
>> Signed-off-by: Mohammad Jamal <md.jamalmohiuddin@...il.com>
>> ---
>>  drivers/net/ieee802154/cc2520.c |    6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
>> index dd129be..b9b2a49 100644
>> --- a/drivers/net/ieee802154/cc2520.c
>> +++ b/drivers/net/ieee802154/cc2520.c
>> @@ -45,9 +45,9 @@
>>  #define        CC2520_FREG_MASK        0x3F
>>
>>  /* status byte values */
>> -#define        CC2520_STATUS_XOSC32M_STABLE    (1 << 7)
>> -#define        CC2520_STATUS_RSSI_VALID        (1 << 6)
>> -#define        CC2520_STATUS_TX_UNDERFLOW      (1 << 3)
>> +#define        CC2520_STATUS_XOSC32M_STABLE    BIT(7)
>> +#define        CC2520_STATUS_RSSI_VALID        BIT(6)
>> +#define        CC2520_STATUS_TX_UNDERFLOW      BIT(3)
>>
>>  /* IEEE-802.15.4 defined constants (2.4 GHz logical channels) */
>>  #define        CC2520_MINCHANNEL               11
>> --
>> 1.7.9.5
>>
>
> Please work on bluetooth-next[1] tree and also include
> 'bluetooth-next' tag for the patch.
>
> [1]: http://git.kernel.org/cgit/linux/kernel/git/bluetooth/bluetooth-next.git/
>
> --
> Thanks and Regards,
> Varka Bhadram.
OK , i will send u the patch once i clone the bluetooth-next tree.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/