linux-kernel - Re: [PATCH v3 3/7] misc: Add cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54C21A7E.1050304@collabora.co.uk>
Date:	Fri, 23 Jan 2015 10:55:10 +0100
From:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
To:	Varka Bhadram <varkabhadram@...il.com>
CC:	Lee Jones <lee.jones@...aro.org>, Olof Johansson <olof@...om.net>,
	Arnd Bergmann <arnd@...db.de>,
	Doug Anderson <dianders@...omium.org>,
	Bill Richardson <wfrichar@...omium.org>,
	Simon Glass <sjg@...gle.com>,
	Gwendal Grignou <gwendal@...gle.com>,
	Jonathan Corbet <corbet@....net>,
	linux-samsung-soc@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 3/7] misc: Add cros_ec_lpc driver for x86 devices

Hello Varka,

Thanks a lot for your feedback.

On 01/23/2015 04:57 AM, Varka Bhadram wrote:
> (...)
>> +static int cros_ec_lpc_probe(struct platform_device *pdev)
>> +{
>> +       struct device *dev = &pdev->dev;
>> +       struct cros_ec_device *ec_dev;
>> +       int err = -ENOTTY;
>> +
>> +       if (!request_region(EC_LPC_ADDR_MEMMAP, EC_MEMMAP_SIZE, MYNAME)) {
> 
> Why dont you use devres API for request_region()... Then maximum of
> your goto label regarding
> release region will gone...
>

Good point, I'll change that on next version.
 
>> +               dev_warn(dev, "couldn't reserve memmap region\n");
>> +               goto failed_memmap;
>> +       }
>> +
>> +       if ((inb(EC_LPC_ADDR_MEMMAP + EC_MEMMAP_ID) != 'E') ||
>> +           (inb(EC_LPC_ADDR_MEMMAP + EC_MEMMAP_ID + 1) != 'C')) {
>> +               dev_warn(dev, "EC ID not detected\n");
>> +               goto failed_ec_probe;
>> +       }
>> +
>> +       if (!request_region(EC_HOST_CMD_REGION0, EC_HOST_CMD_REGION_SIZE,
>> +                           MYNAME)) {
> 
> same...
> 
>> +               dev_warn(dev, "couldn't reserve region0\n");
>> +               goto failed_region0;
>> +       }
>> +       if (!request_region(EC_HOST_CMD_REGION1, EC_HOST_CMD_REGION_SIZE,
>> +                           MYNAME)) {
> 
> same ...
> 
>> +               dev_warn(dev, "couldn't reserve region1\n");
>> +               goto failed_region1;
>> +       }
>> +
>> +       ec_dev = devm_kzalloc(dev, sizeof(*ec_dev), GFP_KERNEL);
>> +       if (!ec_dev) {
>> +               err = -ENOMEM;
>> +               goto failed_ec_dev;
>> +       }
>> +
>> +       platform_set_drvdata(pdev, ec_dev);
>> +       ec_dev->dev = dev;
>> +       ec_dev->ec_name = pdev->name;
>> +       ec_dev->phys_name = dev_name(dev);
>> +       ec_dev->parent = dev;
>> +       ec_dev->cmd_xfer = cros_ec_cmd_xfer_lpc;
>> +       ec_dev->cmd_readmem = cros_ec_lpc_readmem;
>> +
>> +       err = cros_ec_register(ec_dev);
>> +       if (err) {
>> +               dev_warn(dev, "couldn't register ec_dev\n");
>> +               goto failed_ec_dev;
>> +       }
>> +
>> +       return 0;
>> +
>> +failed_ec_dev:
>> +       release_region(EC_HOST_CMD_REGION1, EC_HOST_CMD_REGION_SIZE);
>> +failed_region1:
>> +       release_region(EC_HOST_CMD_REGION0, EC_HOST_CMD_REGION_SIZE);
>> +failed_region0:
>> +failed_ec_probe:
>> +       release_region(EC_LPC_ADDR_MEMMAP, EC_MEMMAP_SIZE);
> 
> All these goto labels will be gone if you use devres API..
> 

Yes, I'll wait a couple more days to see if I get more feedback and re-post.

Best regards,
Javier

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/