| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1422016176-6299-1-git-send-email-martink@posteo.de> Date: Fri, 23 Jan 2015 13:29:36 +0100 From: Martin Kepplinger <martink@...teo.de> To: dmitry.torokhov@...il.com Cc: khoroshilov@...ras.ru, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, Martin Kepplinger <martink@...teo.de> Subject: [PATCH] input: (gtco) use sign_extend32() for sign extension Signed-off-by: Martin Kepplinger <martink@...teo.de> --- Despite it's name, sign_extend32() is safe to use for 8 and 16 bit types too. drivers/input/tablet/gtco.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/input/tablet/gtco.c b/drivers/input/tablet/gtco.c index 8580456..272a838 100644 --- a/drivers/input/tablet/gtco.c +++ b/drivers/input/tablet/gtco.c @@ -59,7 +59,7 @@ Scott Hill shill@...ocalcomp.com #include <asm/uaccess.h> #include <asm/unaligned.h> #include <asm/byteorder.h> - +#include <linux/bitops.h> #include <linux/usb/input.h> @@ -666,13 +666,8 @@ static void gtco_urb_callback(struct urb *urbinfo) case 4: /* Tilt */ - /* Sign extend these 7 bit numbers. */ - if (device->buffer[6] & 0x40) - device->buffer[6] |= 0x80; - - if (device->buffer[7] & 0x40) - device->buffer[7] |= 0x80; - + device->buffer[6] = sign_extend32(device->buffer[6], 6); + device->buffer[7] = sign_extend32(device->buffer[7], 6); valsigned = (device->buffer[6]); input_report_abs(inputdev, ABS_TILT_X, (s32)valsigned); -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists