linux-kernel - Re: [PATCH] modsign: provide option to automatically delete the key after modules were installed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 23 Jan 2015 14:35:16 +0100
From:	Alexander Holler <holler@...oftware.de>
To:	David Howells <dhowells@...hat.com>
CC:	Michal Marek <mmarek@...e.cz>, linux-kernel@...r.kernel.org,
	linux-kbuild@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] modsign: provide option to automatically delete the key
 after modules were installed

Sorry, either I type too fast or I think too slow, so here is another 
comment:

Am 23.01.2015 um 14:27 schrieb Alexander Holler:
> Am 23.01.2015 um 13:56 schrieb David Howells:
>
>> One thing that you have to be careful of with your patch is that if
>> you turn
>> it on during development, this will drain the entropy pool from which
>> you get
>> random numbers.
>
> Hmm, I wonder how often people are compiling kernels and how much one
> turn drains the entropy pool.
>
> I would suggest to just get better in coding (and reviewing before
> compile testing) in order to not having to build kernels that often. Or
> just use a different config for development. ;)
>
> My primary use case is just what Linus described in his keynote. I'm
> building and signing all my kernels whenever a new stable kernel
> appears, throwing away the keys away immediately afterwards.
>
> And the patch avoids that I have to type the rm, and, even more usefull,
> it makes sure I don't forget to delete the keys, which would make
> signing the modules useless for me (as my kernel build directories (and
> thus the private keys) are usually residing on the machine the kernel is
> deployed afterwards).

Besides that the keys are only deleted when modules_install is called. 
And that usually is only called if the kernels execution will be tested 
in real, which should offer enough time to fill the entropy pool. If the 
kernel and the modules are just build (and not installed), the keys will 
not be deleted.

Regards,

Alexander Holler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/