linux-kernel - Re: [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 23 Jan 2015 16:47:55 +0100
From:	Sjoerd Simons <sjoerd.simons@...labora.co.uk>
To:	Javier Martinez Canillas <javier@...hile0.org>
Cc:	Jaehoon Chung <jh80.chung@...sung.com>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>, Kukjin Kim <kgene@...nel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420

On Fri, 2015-01-23 at 15:36 +0100, Javier Martinez Canillas wrote:
> Hello Jaehoon,
> 
> On Fri, Jan 23, 2015 at 3:23 PM, Jaehoon Chung <jh80.chung@...sung.com> wrote:
> > Add sd0_rst node to exynos5420-pinctrl.dtsi.
> > (It's used on odroid-xu3 board)
> >
> 
> It would be good to mention which device needs this pinctrl line.
> 
> > Signed-off-by: Jaehoon Chung <jh80.chung@...sung.com>
> > ---
> >  arch/arm/boot/dts/exynos5420-pinctrl.dtsi |    5 +++++
> 
> If this pin is used by the Odroid XU3 board, shouldn't be defined in
> the exynos5422-odroidxu3.dts instead?

It's not just used by the XU3 though, it's also hooked up on the peach
pi chromebook for example and i would expect it to be hooked up on most
board with an eMMC

This change is consistent with most of the special purpose GPIO pins
defined in that file, so i don't see the problem with including it in
that pinctrl file
-- 
Sjoerd Simons <sjoerd.simons@...labora.co.uk>
Collabora Ltd.

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (6170 bytes)