linux-kernel - Re: [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABxcv=kARp8xLYCqf8dfdKd9ehs1u=qTEjkn1iujhN77ZjPdTA@mail.gmail.com>
Date:	Fri, 23 Jan 2015 16:59:24 +0100
From:	Javier Martinez Canillas <javier@...hile0.org>
To:	Sjoerd Simons <sjoerd.simons@...labora.co.uk>
Cc:	Jaehoon Chung <jh80.chung@...sung.com>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>, Kukjin Kim <kgene@...nel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420

Hello Sjoerd,

On Fri, Jan 23, 2015 at 4:47 PM, Sjoerd Simons
<sjoerd.simons@...labora.co.uk> wrote:
>>
>> If this pin is used by the Odroid XU3 board, shouldn't be defined in
>> the exynos5422-odroidxu3.dts instead?
>
> It's not just used by the XU3 though, it's also hooked up on the peach
> pi chromebook for example and i would expect it to be hooked up on most
> board with an eMMC
>
> This change is consistent with most of the special purpose GPIO pins
> defined in that file, so i don't see the problem with including it in
> that pinctrl file

In that case I completely agree that it should be defined in the .dtsi
but that is not what the commit message said though :-)

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/