linux-kernel - Re: General protection fault in iscsi_rx_thread_pre

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+eFSM3yBoqpb-tjz_ztyUyUV9RQEATVJ6nBWJgXJmbXvjGgQQ@mail.gmail.com>
Date:	Fri, 23 Jan 2015 09:30:37 +0800
From:	Gavin Guo <gavin.guo@...onical.com>
To:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
Cc:	linux-scsi@...r.kernel.org, target-devel@...r.kernel.org,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: General protection fault in iscsi_rx_thread_pre_handler

Hi Nicholas,

On Fri, Jan 23, 2015 at 1:35 AM, Nicholas A. Bellinger
<nab@...ux-iscsi.org> wrote:
> On Thu, 2015-01-22 at 23:56 +0800, Gavin Guo wrote:
>> Hi Nicolas,
>>
>> On Thu, Jan 22, 2015 at 5:50 PM, Nicholas A. Bellinger
>> <nab@...ux-iscsi.org> wrote:
>> > Hi Gavin,
>> >
>> > On Thu, 2015-01-22 at 06:38 +0800, Gavin Guo wrote:
>> >> Hi all,
>> >>
>> >> The general protection fault screenshot is attached.
>> >>
>> >> Summary:
>> >> The kernel is Ubuntu-3.13.0-39.66. I've done basic analysis and found
>> >> the fault is in list_del of iscsi_del_ts_from_active_list. And it
>> >> looks like deleting the iscsi_thread_set *ts two times. The point to
>> >> delete including iscsi_get_ts_from_inactive_list, was also checked but
>> >> still can't find the clue. Really appreciate if anyone can provide any
>> >> idea on the bug.
>> >>
>
> <SNIP>
>
>> >
>> > Thanks for your detailed analysis.
>> >
>> > A similar bug was reported off-list some months back by a person using
>> > iser-target + RoCE export on v3.12.y code.  Just to confirm, your
>> > environment is using traditional iscsi-target + TCP export, right..?
>>
>> I am sorry that I'm not an expert of the field and already google RoCE
>> on the internet but still don't really know what RoCE is. However, I
>> can provide the informations.  We used iscsiadm on the initiator side
>> and lio_node and tcm_node commands to create the targets for
>> connection. I think it should be normal  iscsi-target using TCP
>> export.
>>
>
> Yep, that would be traditional iscsi-target + TCP export.
>
>> >
>> > At the time, a different set of iser-target related changes ended up
>> > avoiding this issue on his particular setup, so we thought it was likely
>> > a race triggered by login failures specific to iser-target code.
>> >
>> > There was a untested patch (included inline below) to drop the legacy
>> > active_ts_list usage all-together, but IIRC he was not able to reproduce
>> > further so the patch didn't get picked up for mainline.
>> >
>> > If your able to reliability reproduce, please try with the following
>> > patch and let us know your progress.
>>
>> Thanks for your time reading the mail. I'll let you know the result.
>
> Just curious, are you able to reliability reproduce this bug in a VM..?

Thanks for your caring, the machine is on the customer side, I've
asked and now waiting for their response.

>
> --nab
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/