linux-kernel - Re: [PATCH v2 23/30] PCI/mvebu: Use pci_common_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54C1ADE3.9060606@huawei.com>
Date:	Fri, 23 Jan 2015 10:11:47 +0800
From:	Yijing Wang <wangyijing@...wei.com>
To:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
CC:	Lior Amsalem <alior@...vell.com>, <linux-ia64@...r.kernel.org>,
	<linux-pci@...r.kernel.org>, Nadav Haklai <nadavh@...vell.com>,
	Gregory Clément 
	<gregory.clement@...e-electrons.com>,
	"Guan Xuetao" <gxt@...c.pku.edu.cn>,
	Russell King <linux@....linux.org.uk>, <x86@...nel.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	"Benjamin Herrenschmidt" <benh@...nel.crashing.org>,
	Jason Cooper <jason@...edaemon.net>,
	Arnd Bergmann <arnd@...db.de>,
	Marc Zyngier <marc.zyngier@....com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	<linux-m68k@...ts.linux-m68k.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Yinghai Lu <yinghai@...nel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	Liviu Dudau <liviu@...au.co.uk>,
	"Tony Luck" <tony.luck@...el.com>, <linux-kernel@...r.kernel.org>,
	Jiang Liu <jiang.liu@...ux.intel.com>,
	<linux-alpha@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH v2 23/30] PCI/mvebu: Use pci_common_init_dev() to simplify
 code

On 2015/1/23 1:40, Thomas Petazzoni wrote:
> Dear Yijing Wang,
> 
> On Wed, 21 Jan 2015 08:30:18 +0800, Yijing Wang wrote:
>> Mvebu_pcie_scan_bus() is not necessary, we could use
>> pci_common_init_dev() instead of pci_common_init(),
>> and pass the device pointer as the parent. Then
>> pci_scan_root_bus() will be called to scan the pci busses.
>>
>> Signed-off-by: Yijing Wang <wangyijing@...wei.com>
>> CC: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
>> CC: Jason Cooper <jason@...edaemon.net>
> 
> While I'm fine with the change to pci_common_init_dev(), I am not so
> sure about the removal of mvebu_pcie_scan_bus(). I vaguely remember
> that we intentionally did not use the default function for a specific
> reason. Of course, this was a long time ago, and I don't remember the
> reason. I would have to take a bit of time to 1/ review the archives of
> the discussion surrounding the pcie-mvebu driver, and 2/ test your
> patch to validate it works fine on HW.

Hi Thomas, Thanks for your comments and help to test :)

> 
> Thanks!
> 
> Thomas
> 


-- 
Thanks!
Yijing

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/