linux-kernel - Re: [PATCH] ARM: dts: sun4i: Add initial dts for Gemei G9 tablet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150124143945.GD8470@lukather>
Date:	Sat, 24 Jan 2015 15:39:45 +0100
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Priit Laes <plaes@...es.org>
Cc:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: sun4i: Add initial dts for Gemei G9 tablet

Hi,

On Fri, Jan 23, 2015 at 11:59:35PM +0200, Priit Laes wrote:
> 
> On Fri, 2015-01-23 at 22:22 +0100, Maxime Ripard wrote:
> > On Fri, Jan 23, 2015 at 10:36:49PM +0200, Priit Laes wrote:
> > > Gemei G9 is an A10 based tablet, with 1G RAM, 16G NAND, 1024x768 
> > > IPS LCD display, stereo speakers, 1.3MP front camera and 5 MP
> > > rear camera, 8000mAh battery, GT901 2+1 touchscreen, Bosch BMA250 
> > > accelerometer and RTL8188CUS USB wifi. It also has MicroSD slot, 
> > > miniHDMI, 1 x MicroUSB OTG port and 1 x MicroUSB host port and 
> > > 3.5mm headphone jack.
> > > More details are available at: http://linux-sunxi.org/Gemei_G9
> > > 
> [..]
> > > 
> > > +/ {
> > > +    model = "Gemei G9 Tablet";
> > > +    compatible = "gemei,g9", "allwinner,sun4i-a10";
> > > +};
> > > +
> > > +/*
> > > + * http://linux-sunxi.org/Gemei_G9
> > 
> > Please don't put URL in the DT. This is very likely to change in the 
> > future, and won't be valid anymore.
> 
> OK! The URL in commit message is ok to stay?

Yeah, I'm not that fond of it, but it's not that important either.

> > > +&i2c1 {
> > > +    pinctrl-names = "default";
> > > +    pinctrl-0 = <&i2c1_pins_a>;
> > > +    status = "okay";
> > > +
> > > +    /* Accelerometer */
> > > +    bma250@18 {
> > > +        compatible = "bosch,bma250";
> > > +        reg = <0x18>;
> > 
> > Is there a driver for this? It looks weird that it doesn't need more 
> > properties than that.
> 
> Yes, it's supported by drivers/iio/accel/bma180.c though I have to 
> admit that this name is a bit misleading. (bosch-bma.c would 
> better, I guess).
> 
> And I was a bit surprised that it worked out of the box too, but the 
> device was present under /sys and I was able to read x, y, z and 
> temperature values.

Cool :)

There's no interrupt wired to it then?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)