linux-kernel - Re: [PATCH] lib/kstrtox.c clean kstrtoll function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150124193031.GG40116@unpythonic.net>
Date:	Sat, 24 Jan 2015 13:30:32 -0600
From:	Jeff Epler <jepler@...ythonic.net>
To:	Anshul Garg <aksgarg1989@...il.com>
Cc:	akpm@...ux-foundation.org, Levente Kurusa <levex@...ux.com>,
	Felipe Contreras <felipe.contreras@...il.com>,
	linux-kernel@...r.kernel.org,
	"anshul.g@...sung.com" <anshul.g@...sung.com>
Subject: Re: [PATCH] lib/kstrtox.c clean kstrtoll function


On Fri, Jan 23, 2015 at 06:55:36PM +0530, Anshul Garg wrote:
> if (((long long)tmp < LLONG_MIN) || ((long long)tmp > LLONG_MAX) )
> + return -ERANGE;

This proposed code is still wrong (-ERANGE can never be returned by this
statement).  It may be best to leave the code alone, rather than propose
more untested alternatives.

Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/