linux-kernel - Re: [PATCH 1/4] staging: vt6655: correcting function declaration sparse error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150125113959.GA22997@kroah.com>
Date:	Sun, 25 Jan 2015 19:39:59 +0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	mathieu.poirier@...aro.org
Cc:	forest@...ttletooquiet.net, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] staging: vt6655: correcting function declaration
 sparse error

On Sat, Jan 17, 2015 at 07:04:23PM -0700, mathieu.poirier@...aro.org wrote:
> From: Mathieu Poirier <mathieu.poirier@...aro.org>
> 
> mpoirier@...0:~/work/kernel1$ make C=1 M=drivers/staging/vt6655/
>   LD      drivers/staging/vt6655/built-in.o
>   CHECK   drivers/staging/vt6655/device_main.c
> drivers/staging/vt6655/device_main.c:1672:5: warning: symbol 'vnt_init' was not declared. Should it be static?
>   CC [M]  drivers/staging/vt6655/device_main.o
> 
> Function @vnt_init is only called by @vt6655_probe, in turn is declared "static".
> As sparse suggest, @vnt_init should very likely be declared static as well.  At
> least nothing in the file indicate that it should be otherwise.
> 
> Signed-off-by: Mathieu Poirier <mathieu.poirier@...aro.org>
> ---
>  drivers/staging/vt6655/device_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This whole series does not apply to my staging-next branch, of
staging.git, please refresh against it and resend if it is still needed
(hint, I don't think they all are...)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/