linux-kernel - Re: [PATCH 4/5] tools lib api fs: Add {tracefs,debugfs}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 25 Jan 2015 14:27:26 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jiri Olsa <jolsa@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH 4/5] tools lib api fs: Add
 {tracefs,debugfs}_configured() functions

On Sun, 25 Jan 2015 18:02:03 +0100
Jiri Olsa <jolsa@...hat.com> wrote:

> On Sat, Jan 24, 2015 at 01:13:34PM -0500, Steven Rostedt wrote:
> 
> SNIP
> 
> >  #include <sys/mount.h>
> >  #include <linux/kernel.h>
> >  
> > @@ -24,6 +27,16 @@ static const char * const debugfs_known_mountpoints[] = {
> >  
> >  static bool debugfs_found;
> >  
> > +bool debugfs_configured(void)
> > +{
> > +	struct stat st;
> > +
> > +	if (stat(DEBUGFS_DEFAULT_PATH, &st) < 0)
> > +		return false;
> > +
> 
> hum, should  this function rather do
> 
> bool debugfs_configured(void)
> {
> 	return debugfs_find_mountpoint() != NULL;
> }
> 
> 
> SNIP
> 
> >  static bool tracefs_found;
> >  
> > +bool tracefs_configured(void)
> > +{
> > +	struct stat st;
> > +
> > +	if (stat(TRACEFS_DEFAULT_PATH, &st) < 0)
> > +		return false;
> > +
> > +	return true;
> > +}
> 
> same for this one..


OK, will change.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/