linux-kernel - Re: [PATCH 3.10 25/50] gpiolib: of: Correct error handling in of_get_named_gpiod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150125220518.GA29924@kroah.com>
Date:	Sun, 25 Jan 2015 14:05:18 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Hans Holmberg <hans.holmberg@...el.com>,
	Alexandre Courbot <acourbot@...dia.com>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH 3.10 25/50] gpiolib: of: Correct error handling in
 of_get_named_gpiod_flags

On Sun, Jan 25, 2015 at 01:31:49PM -0800, Guenter Roeck wrote:
> On Sun, Jan 25, 2015 at 10:07:15AM -0800, Greg Kroah-Hartman wrote:
> > 3.10-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Hans Holmberg <hans.holmberg@...el.com>
> > 
> > commit 7b8792bbdffdff3abda704f89c6a45ea97afdc62 upstream.
> > 
> > of_get_named_gpiod_flags fails with -EPROBE_DEFER in cases
> > where the gpio chip is available and the GPIO translation fails.
> > 
> > This causes drivers to be re-probed erroneusly, and hides the
> > real problem(i.e. the GPIO number being out of range).
> > 
> > Signed-off-by: Hans Holmberg <hans.holmberg@...el.com>
> > Reviewed-by: Alexandre Courbot <acourbot@...dia.com>
> > Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > 
> 
> This patch is causing several build failures.
> 
> Error log:
> drivers/gpio/gpiolib-of.c: In function 'of_gpiochip_find_and_xlate':
> drivers/gpio/gpiolib-of.c:50:3: error: implicit declaration of function 'ERR_PTR'
> 
> since "#include <linux/err.h>" is missing in drivers/gpio/gpiolib-of.c
> in the 3.10 kernel.

Thanks for letting me know, I've pushed out a fix for this in the quilt
tree of patches.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/