linux-kernel - Re: Backport of spi-fsl-spi bugfix to 3.14.y

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 25 Jan 2015 14:07:23 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Mark Brown <broonie@...nel.org>
Cc:	Esben Haabendal <esben.haabendal@...il.com>,
	stable@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-spi@...r.kernel.org, Stefan Roese <sr@...x.de>
Subject: Re: Backport of spi-fsl-spi bugfix to 3.14.y

On Sun, Jan 25, 2015 at 08:12:54PM +0000, Mark Brown wrote:
> On Sun, Jan 25, 2015 at 09:38:53AM -0800, Greg Kroah-Hartman wrote:
> > On Fri, Jan 23, 2015 at 12:45:29PM +0000, Mark Brown wrote:
> 
> > > So, I now see this has actually been merged into stable without getting
> > > to the bottom of why it's helping anything...  this is a bit worrying
> > > since it's adding new functionality and not really a bug fix.  It'd have
> > > been good to at least get a followup here.
> 
> > Do you want me to revert something from the stable tree?  If so, has it
> > also been reverted upstream?
> 
> The patch just isn't an obvious -stable patch - it's adding new
> functionality, not fixing a bug, and I was surprised to discover it had
> been added as a result.  It's fine as new functionality and therefore
> hasn't been reverted upstream.
> 
> We can probably leave it there, though if this is OK that's a bit of a
> change, but if this new functionality is a good fix then we're probably
> leaving other systems unfixed which isn't good, I would be very much
> happier if we understood what had changed here.  If new functionality is
> OK there's a probably a bunch of other changes we should be pulling
> back.

New functionality shouldn't be added, but sometimes things slip in due
to the volume of patches and how people word-smith changelog entries :(

greg k-h

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/