linux-kernel - Re: [PATCH] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...

Open Source and information security mailing list archives

Message-ID: <20150125141420.GA4046@localhost.localdomain>
Date:	Sun, 25 Jan 2015 16:14:20 +0200
From:	Aya Mahfouz <mahfouz.saif.elyazal@...il.com>
To:	Heba Aamer <heba93aamer@...il.com>
Cc:	devel@...verdev.osuosl.org, florian.c.schilhabel@...glemail.com,
	thomas@...uk.net, tapaswenipathak@...il.com,
	gregkh@...uxfoundation.org, rickard_strandqvist@...ctrumdigital.se,
	linux-kernel@...r.kernel.org, sudipm.mukherjee@...il.com,
	Larry.Finger@...inger.net
Subject: Re: [PATCH] staging: rtl8712: fix Prefer [subsystem eg:
 netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(...  to
 printk(KERN_INFO ...

On Sat, Jan 24, 2015 at 10:20:53PM +0200, Heba Aamer wrote:
> This patch fixes the following checkpatch.pl warning:
> fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
> dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...
> 
> netdev_info was used since it is a network subsystem
> 
> Signed-off-by: Heba Aamer <heba93aamer@...il.com>
> ---
>  drivers/staging/rtl8712/usb_intf.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
> index 7d0d171..7748a75 100644
> --- a/drivers/staging/rtl8712/usb_intf.c
> +++ b/drivers/staging/rtl8712/usb_intf.c
> @@ -366,7 +366,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,
>  	struct net_device *pnetdev;
>  	struct usb_device *udev;
>  
> -	printk(KERN_INFO "r8712u: Staging version\n");
> +	netdev_info(pnetdev, "r8712u: Staging version\n");

I've applied your patch and there is one problem here, pnetdev is not initialized yet.
It's better to use pr_info for now.

Kind Regards,
Aya Saif El-yazal Mahfouz

>  	/* In this probe function, O.S. will provide the usb interface pointer
>  	 * to driver. We have to increase the reference count of the usb device
>  	 * structure by using the usb_get_dev function.
> -- 
> 1.7.9.5
> 
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives