linux-kernel - Re: [Patch v2 2/2] firmware: dmi-sysfs: add SMBIOS entry point area attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKv+Gu8_ND+6Ep+WT8qBZ=ASLHQOxP_eMD9LhtogMb1ifMWsVw@mail.gmail.com>
Date:	Mon, 26 Jan 2015 13:34:47 +0000
From:	Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:	Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>,
	"x86@...nel.org" <x86@...nel.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	dmidecode-devel@...gnu.org, Grant Likely <grant.likely@...aro.org>,
	Leif Lindholm <leif.lindholm@...aro.org>,
	Matt Fleming <matt.fleming@...el.com>
Subject: Re: [Patch v2 2/2] firmware: dmi-sysfs: add SMBIOS entry point area attribute

On 26 January 2015 at 13:28, Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org> wrote:
> There are situations when code needs to access SMBIOS entry table
> area, but cannot use /dev/mem for this. As the table format is
> consistent only for a version, and can be changed, use binary
> attribute to give access to raw SMBIOS entry table area.
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>

> ---
>  drivers/firmware/dmi-sysfs.c | 42 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>
> diff --git a/drivers/firmware/dmi-sysfs.c b/drivers/firmware/dmi-sysfs.c
> index e0f1cb3..61b6a38 100644
> --- a/drivers/firmware/dmi-sysfs.c
> +++ b/drivers/firmware/dmi-sysfs.c
> @@ -29,6 +29,8 @@
>  #define MAX_ENTRY_TYPE 255 /* Most of these aren't used, but we consider
>                               the top entry type is only 8 bits */
>
> +static const u8 *smbios_raw_header;
> +
>  struct dmi_sysfs_entry {
>         struct dmi_header dh;
>         struct kobject kobj;
> @@ -646,9 +648,37 @@ static void cleanup_entry_list(void)
>         }
>  }
>
> +static ssize_t smbios_entry_area_raw_read(struct file *filp,
> +                                         struct kobject *kobj,
> +                                         struct bin_attribute *bin_attr,
> +                                         char *buf, loff_t pos, size_t count)
> +{
> +       ssize_t size;
> +
> +       size = bin_attr->size;
> +
> +       if (size > pos)
> +               size -= pos;
> +       else
> +               return 0;
> +
> +       if (count < size)
> +               size = count;
> +
> +       memcpy(buf, &smbios_raw_header[pos], size);
> +
> +       return size;
> +}
> +
> +static struct bin_attribute smbios_raw_area_attr = {
> +       .read = smbios_entry_area_raw_read,
> +       .attr = {.name = "smbios_raw_header", .mode = 0400},
> +};
> +
>  static int __init dmi_sysfs_init(void)
>  {
>         int error = -ENOMEM;
> +       int size;
>         int val;
>
>         /* Set up our directory */
> @@ -669,6 +699,18 @@ static int __init dmi_sysfs_init(void)
>                 goto err;
>         }
>
> +       smbios_raw_header = dmi_get_smbios_entry_area(&size);
> +       if (!smbios_raw_header) {
> +               pr_debug("dmi-sysfs: SMBIOS raw data is not available.\n");
> +               error = -ENODATA;
> +               goto err;
> +       }
> +
> +       /* Create the raw binary file to access the entry area */
> +       smbios_raw_area_attr.size = size;
> +       if (sysfs_create_bin_file(dmi_kobj, &smbios_raw_area_attr))
> +               goto err;
> +
>         pr_debug("dmi-sysfs: loaded.\n");
>
>         return 0;
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/