linux-kernel - Re: [PATCH] memcg: fix static checker warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150126133733.GA22689@dhcp22.suse.cz>
Date:	Mon, 26 Jan 2015 14:37:33 +0100
From:	Michal Hocko <mhocko@...e.cz>
To:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] memcg: fix static checker warning

On Mon 26-01-15 14:44:08, Kirill A. Shutemov wrote:
> The patch "mm: remove rest usage of VM_NONLINEAR and pte_file()" from
> Jan 17, 2015, leads to the following static checker warning:
> 
>         mm/memcontrol.c:4794 mc_handle_file_pte()
>         warn: passing uninitialized 'pgoff'
> 
> After the patch, the only case when mc_handle_file_pte() called is
> pte_none(ptent). The 'if' check is redundant and lead to the warning.
> Let's drop it.
> 
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>

Acked-by: Michal Hocko <mhocko@...e.cz>

> ---
>  mm/memcontrol.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index cd42f14d138a..a6140c0764f4 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -4792,8 +4792,7 @@ static struct page *mc_handle_file_pte(struct vm_area_struct *vma,
>  		return NULL;
>  
>  	mapping = vma->vm_file->f_mapping;
> -	if (pte_none(ptent))
> -		pgoff = linear_page_index(vma, addr);
> +	pgoff = linear_page_index(vma, addr);
>  
>  	/* page is moved even if it's not RSS of this task(page-faulted). */
>  #ifdef CONFIG_SWAP
> -- 
> 2.1.4
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>

-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/