linux-kernel - Re: [PATCH 2/5] tools lib api fs: Add tracefs mount helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150126092621.263160aa@gandalf.local.home>
Date:	Mon, 26 Jan 2015 09:26:21 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jiri Olsa <jolsa@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH 2/5] tools lib api fs: Add tracefs mount helper
 functions

On Mon, 26 Jan 2015 10:02:55 +0100
Jiri Olsa <jolsa@...hat.com> wrote:

> > Note, WTF is perf checking the magic number for debugfs?? If events
> > move, even if its at the same path, this will break perf!
> 
> good question.. it's there since 2009:
>   f6bdafef2ab9 perf_counter: Add tracepoint support to perf list, perf stat
> 
> I guess we didn't want anyone to trick us with fake tracepoints ;-)

But that would be a feature not a bug. I could imagine admins doing
this for some work around.

But can we nuke that check? I don't think it's very useful.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/