linux-kernel - Re: [PATCH_V2 2/4] dt: sound: jz4740: Add binding documentation for jz4740-i2s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5212689.3MTQUevMKn@wuerfel>
Date:	Mon, 26 Jan 2015 15:27:17 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>
Cc:	tiwai@...e.de, perex@...ex.cz, broonie@...nel.org,
	lgirdwood@...il.com, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, alsa-devel@...a-project.org,
	lars@...afoo.de
Subject: Re: [PATCH_V2 2/4] dt: sound: jz4740: Add binding documentation for jz4740-i2s

On Monday 26 January 2015 13:15:36 Zubair Lutfullah Kakakhel wrote:
> +
> +Required properties:
> +- compatible : "ingenic,jz4740-i2s"
> +- reg : I2S registers location and length
> +- clocks : AIC and I2S PLL clock specifiers.
> +- clock-names: "aic" and "i2s"
> +
> +Example:
> +
> +i2s: i2s@...20000 {
> +       compatible = "ingenic,jz4740-i2s";
> +       reg = <0x10020000 0x94>;
> +
> +       clocks = <&cgu JZ4740_CLK_AIC>, <&cgu JZ4740_CLK_I2SPLL>;
> +       clock-names = "aic", "i2s";
> +
> +       dmas = <&dma 2>, <&dma 3>;
> +       dma-names = "tx", "rx";
> +
> 

Thanks for adding the dma entries to the example. Unfortunately you
have missed adding them to the list of required properties,
so please add those as well.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/